New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: EcoAssist: A no-code platform to train and deploy custom YOLOv5 object detection models #5581
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
|
👋🏼 @PetervanLunteren, @animikhaich, @oparisot, this is the review thread for the paper. All of our communications will happen here from now on. As a reviewer, the first step is to create a checklist for your review by entering
as the top of a new comment in this thread. There are additional guidelines in the message at the start of this issue. Please don't hesitate to ping me (@mstimberg) if you have any questions/concerns. |
👋 @animikhaich, @oparisot, no rush for performing the actual review of course, but just checking in to see whether there are any questions on your side or whether there's anything else I can do to help you with the review? Please be reminded that JOSS reviews can be iterative, i.e. feel free to open issues or comment here as soon as you come across concerns – there is no need to gather everything into a single review text as commonly done for traditional journals. In the same vein, please feel free to tick boxes in your checklist whenever you are sure about them (the two in the beginning – conflict of interest and code of conduct – would be good first candidates 😉 ). Thank you for your time 🙏 ! |
Hi @mstimberg, Thanks for your message. Apologies for the delay. I had a medical situation over the past two weeks and went through a major surgery. I am in recovery and should be able to initiate the review by the end of this week. |
@animikhaich Sorry to hear about your medical issues, thank you for taking the time to reply. It goes without saying that getting well again should be your priority, not this review, so please don't feel pressured to finish it any time soon. We are grateful for your time in either case, and I am sure the authors understand that sometimes more important things get into the way. Also, please don't hesitate to contact me directly (marcel.stimberg@inserm.fr) in case you want to discuss things you might not be comfortable sharing in a public GitHub issue. Thanks again for your time and for replying, get well soon 🙏 . |
@mstimberg @animikhaich Yes of course, it goes without saying that I completely understand. There is no rush! |
Review checklist for @animikhaichConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
👋 @oparisot did you have the time to look at the EcoAssist software/paper yet? |
Review checklist for @oparisotConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@mstimberg Hello, this software is really interesting! |
@mstimberg @animikhaich @oparisot Thanks for your time! I'm not too familiar with the review process. Are the unchecked boxes areas where the software performs poorly? In other words, are the unchecked boxes actions for me to revise? |
@PetervanLunteren Unchecked boxes could mean that there is something to improve in the software/paper, but in that case the reviewers would either leave more specific comments here or open issues in your repository. In this case, it most likely simply means that the reviewers did not yet have the time to verify the unchecked criteria in detail. |
Hello @PetervanLunteren !! I checked again the list -- I forgot to check two points, my review is up to date now. Two minor points:
Olivier |
My checklist is updated. There is an error that is preventing me from running the standard test case and moving forward. I've opened an issue here. Please address the same and let me know if you need anything else. A couple of points that need to be addressed:
Best, |
Hi @oparisot, Thanks very much for your time! Please see my responses below.
Indeed, there are currently no automated tests available. I have included documented manual steps for this purpose. I thought/hoped this to be sufficient for the JOSS review criteria, but if not: let me know. In that case I'll revise.
Yes, there are similar packages available. I briefly discuss them in the paper (line 36-40). Do you advise me to expand on this? Thanks, |
Hello @PetervanLunteren , Ok for me for the tests, the documentation is sufficient. Olivier |
Thanks for the tip, I've added a section to the documentation: https://github.com/PetervanLunteren/EcoAssist#similar-software Peter |
Hi @animikhaich, thanks for your time and suggestions! I'll respond to them below.
Thanks for opening this issue and providing the detailed information. I've looked into it and it seems that it is not directly an EcoAssist issue, but rather a MegaDetector issue regarding the CUDA software that comes with the MegaDetector installation. I've opened an issue at the relevant repository and hope to resolve your problem together with the developers there. Any further communication about this will happen in the issue PetervanLunteren/EcoAssist#16.
Thanks for letting me know. Please see the updated repository, where I've updated the documentation and added a
This does indeed look great! I will look into this to make the installation more robust. However, since containerizing the program does ask for quite some time investment and the moment I do not have much spare time, I can't promise an ETA. Since it is not necessary for the JOSS publication, I'll add it to my TODO list and will look into it when time permits. I really appreciate the tip! |
@PetervanLunteren, Thanks for addressing the issues. I've updated the checklist based on the CONTRIBUTING guidelines. Since I cannot test the code on my GPU system due to the CUDA Error, I'll test it out on my Macbook and update the checklist based on the same. |
Post-Review Checklist for Editor and AuthorsAdditional Author Tasks After Review is Complete
Editor Tasks Prior to Acceptance
|
@editorialbot check references |
|
@PetervanLunteren All looks very good to me, I only open a small PR fixing two of the references. Just to check: am I correct that the software itself did not change during the review process, i.e. version v4.0 and the Zenodo archive at https://doi.org/10.5281/zenodo.7223363 are still the most recent ones? |
@mstimberg Yes, that is correct. Those are the latest versions. |
@editorialbot set 10.5281/zenodo.7223363 as archive |
Done! archive is now 10.5281/zenodo.7223363 |
Could you please manually fix some of the metadata in the Zenodo archive (no need to to a new tag/release)? In general, we prefer to have the archive metadata to be as consistent as possible with the JOSS paper. In particular, could you make the titles and author lists match? If you want to leave
If you want to make sure that this information will be correctly filled out in the feature when using the automatic GitHub-Zenodo bridge, you can specify them in a |
I've manually adjusted the details on Zenodo. Could you check if this is sufficient? |
All good now 👍 |
@editorialbot generate pdf |
Excellent work everyone, thanks again @PetervanLunteren for choosing to publish with JOSS, and @animikhaich and @oparisot for taking the time to review the software. I will now recommend acceptance and trigger the final steps in the publication process (after confirmation by an editor-in-chief) 🎉 . |
@editorialbot recommend-accept |
|
|
👋 @openjournals/dsais-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#4444, then you can now move forward with accepting the submission by compiling again with the command |
@mstimberg @animikhaich @oparisot thank you very much for your time! |
@PetervanLunteren you're welcome! |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @PetervanLunteren (Peter van Lunteren)
Repository: https://github.com/PetervanLunteren/EcoAssist
Branch with paper.md (empty if default branch): JOSS-submission
Version: v4.0
Editor: @mstimberg
Reviewers: @animikhaich, @oparisot
Archive: 10.5281/zenodo.7223363
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@animikhaich & @oparisot, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @mstimberg know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @animikhaich
📝 Checklist for @oparisot
The text was updated successfully, but these errors were encountered: