New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: Hyperelastics.jl: A Julia package for hyperelastic1 material modelling with a large collection of models #6314
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
Review checklist for @SotaYoshidaConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@cfarm6 I started reviewing. |
Review checklist for @fb456Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Hi @cfarm6! I've also started the review. I have submitted a few issues already that should be addressed, specifically about: I'll continue my review next week and let you know if any more issues arise. |
@SotaYoshida Just a kind reminder |
Thank you for reminding me. |
This package is an excellent effort to implement over 70 hyperelastic material models in the Julia language. Minor comments from me are as follows:
|
@fb456 This is just a kind reminder to complete the review process. |
Hi, |
@cfarm6 can you address the issues stated? |
@AnjaliSandip Yes. I will have the corrections made by the end of this week. |
@cfarm6, could you provide a timeline for wrapping up the corrections suggested? |
@AnjaliSandip Yes, I will be finishing up the suggested corrections later today. |
@AnjaliSandip The issues have been addressed by adding a section for comparisons with other open-source and commercial packages and a section detailing a common use case for the package. |
@SotaYoshida @fb456 Could you review the changes made? |
Hi, I think the issues above have been addressed. One very very minor comment from me is that, referring to the comment above, the information about the recommended version of Julia could also be included in the docs. Otherwise, I recommend the publication of the paper and the package! |
@fb456 I have added statements to the installation instructions in the README and the documentation to reference the compatible Julia versions. In addition, the package is unavailable in older versions as I have only listed compatibility for Julia 1.9+ in the Project.toml file. The updates in the documentation should appear in about 20 minutes once they finish rebuilding. |
@editorialbot generate pdf |
@AnjaliSandip Confirmed the changes made. I am happy to recommend this paper and package for publication. |
@editorialbot set 10.5281/zenodo.10903235 as archive |
Done! archive is now 10.5281/zenodo.10903235 |
Post-Review Checklist for Editor and AuthorsAdditional Author Tasks After Review is Complete
Editor Tasks Prior to Acceptance
|
@editorialbot set v0.1.3 as version |
Done! version is now v0.1.3 |
@editorialbot generate pdf |
@editorialbot check references |
|
@editorialbot recommend-accept |
|
👋 @openjournals/pe-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5196, then you can now move forward with accepting the submission by compiling again with the command |
|
Hi @cfarm6, I'm doing some final checks before publishing.
|
@kyleniemeyer Thank you. Those changes have been made. |
@editorialbot generate pdf |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congratulations @cfarm6 on your article's publication in JOSS! Please consider signing up as a reviewer if you haven't already. Many thanks to @fb456 and @SotaYoshida for reviewing this, and @AnjaliSandip for editing. |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @cfarm6 (Carson Farmer)
Repository: https://github.com/TRACER-LULab/Hyperelastics.jl
Branch with paper.md (empty if default branch):
Version: v0.1.3
Editor: @AnjaliSandip
Reviewers: @fb456, @SotaYoshida
Archive: 10.5281/zenodo.10903235
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@fb456 & @SotaYoshida, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @AnjaliSandip know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @SotaYoshida
📝 Checklist for @fb456
The text was updated successfully, but these errors were encountered: