New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PRE REVIEW]: NLSE: A Python package to solve the nonlinear Schrödinger equation #6509
Comments
Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Software report:
Commit count by author:
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
License info: ✅ License found: |
@editorialbot invite @RMeli as editor |
Invitation to edit this submission sent! |
@editorialbot assign me as editor |
Assigned! @RMeli is now the editor |
Hi @AlexBuccheri 👋 I know you recently reviewed for JOSS (thanks for that, really appreciated!). But would you be interested in reviewing this submission as well? (Totally fine if you have to decline.) Thank you in advance! |
Hi @rashatwi 👋 Would you be interested in reviewing this submission for JOSS (Journal of Open Source Software)? You can find more information about the submission at the top of this Github issue #6509.
Thank you in advance! |
Hi @PhilipVinc 👋 Would you be interested in reviewing this submission for JOSS (Journal of Open Source Software)? You can find more information about the submission at the top of this Github issue #6509.
Thank you in advance! |
Sorry, reviewing too many things right now... |
@RMeli This paper is interesting for me to review. Let me know if I can volunteer for the same. 😊 |
@PhilipVinc no worries, thank you for letting me know! |
@editorialbot add @Abinashbunty as reviewer Yes, thanks for volunteering! |
@Abinashbunty added to the reviewers list! |
Hi @RMeli , apologies but I don't have time for this one (and also don't know anything about the nonlinear Schrödinger equation 😅) |
No worries, thanks @AlexBuccheri! |
@taladjidi thank you for submitting to JOSS. While I look for reviewers, I started having a look at the code base and I noticed the following:
Could you please address the previous two points (proper testing, decoupling between calculations and analysis, removal of pervasive code duplication)? |
Hi, thank you for getting back to me so quickly. Trying to slowly work my way from "physicist" code to actual code 😅 I'll get right on it. I'll add a new comment once this is done. |
@taladjidi no worries, I totally get where you are coming from. If you need any suggestions do let me know. |
@RMeli I significantly refactored the code:
|
@editorialbot check repository |
Software report:
Commit count by author:
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
License info: ✅ License found: |
Thanks @taladjidi. I'll start looking for additional reviewers.
Loos like |
Hi, yes I saw. I did not manage to replicate the issue. I thought it might be a cache issue since I do a lot of jitting, but even when I clear all caches, I do not manage to replicate this zero norm problem (I created an environment cloning the packages versions used by GitHub). I'll spend some more energy on this today ! |
@RMeli all good now ! It was an overflow error due to some edge case in the solver's resolution. Now everything passes 🥳 |
Thanks for the update @taladjidi. Some of the tests you added don't seem very meaningful ( |
Hi @HugoStrand 👋 Would you be interested in reviewing this submission for JOSS (Journal of Open Source Software)? You can find more information about the submission at the top of this Github issue #6509.
Thank you in advance! |
Would you be interested in reviewing this submission for JOSS (Journal of Open Source Software)? You can find more information about the submission at the top of this Github issue #6509.
Thank you in advance! |
Hey @RMeli, sure thing! |
@editorialbot assign @obliviateandsurrender as reviewer Thank you! |
I'm sorry human, I don't understand that. You can see what commands I support by typing:
|
@editorialbot add @obliviateandsurrender as reviewer |
@obliviateandsurrender added to the reviewers list! |
Thank you @Abinashbunty and @obliviateandsurrender for agreeing to review for JOSS. I'll soon start the review process, closing this PRE-REVIEW issue and opening a REVIEW issue for the actual review. If it's your first time reviewing for JOSS, please have a look at the following pages: A good way to review is to open issues in the software repository, and link them to the (soon-to-be-open) review issue. Do not hesitate to ping me with any questions you might have. |
@editorialbot start review |
OK, I've started the review over in #6607. |
Submitting author: @taladjidi (Tangui Aladjidi)
Repository: https://github.com/Quantum-Optics-LKB/NLSE
Branch with paper.md (empty if default branch):
Version: 2.0.0
Editor: @RMeli
Reviewers: @Abinashbunty, @obliviateandsurrender
Managing EiC: Kyle Niemeyer
Status
Status badge code:
Author instructions
Thanks for submitting your paper to JOSS @taladjidi. Currently, there isn't a JOSS editor assigned to your paper.
@taladjidi if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.
Editor instructions
The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:
The text was updated successfully, but these errors were encountered: