Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: Eaglescope: an interactive visualization and cohort selection tool for biomedical data exploration. #6700

Closed
editorialbot opened this issue Apr 30, 2024 · 36 comments
Assignees
Labels
CSS HTML JavaScript pre-review Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Apr 30, 2024

Submitting author: @birm (Ryan Birmingham)
Repository: https://github.com/sharmalab/eaglescope
Branch with paper.md (empty if default branch):
Version: 1.0
Editor: @csoneson
Reviewers: @flekschas, @sebastian-raubach
Managing EiC: Kevin M. Moerman

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/229f0d11e01fb7316ef9da35d9e466ae"><img src="https://joss.theoj.org/papers/229f0d11e01fb7316ef9da35d9e466ae/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/229f0d11e01fb7316ef9da35d9e466ae/status.svg)](https://joss.theoj.org/papers/229f0d11e01fb7316ef9da35d9e466ae)

Author instructions

Thanks for submitting your paper to JOSS @birm. Currently, there isn't a JOSS editor assigned to your paper.

@birm if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials labels Apr 30, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=1.06 s (1682.6 files/s, 234202.0 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
JavaScript                     101           6936          22483         133167
SVG                           1567              0             24          24921
JSON                            15              3              0          22546
CSS                             44           4888            551          21120
Sass                            19            519             34           4755
LESS                            18            504             55           4636
HTML                             8             69             53            673
CSV                              1              0              0            302
Markdown                         5             33              0            151
YAML                             5             15              4             79
TeX                              1              5              0             45
Dockerfile                       1              3              0             15
Bourne Shell                     1              0              0              3
-------------------------------------------------------------------------------
SUM:                          1786          12975          23204         212413
-------------------------------------------------------------------------------

Commit count by author:

   143	Ryan Birmingham
    32	Birm
    19	Yahia Zakaria
    17	Nan Li
     9	Jasox NaN
     7	Mohamed Nasser
     3	nanli-emory
     1	ArthurMor4is
     1	Pranav
     1	dependabot[bot]

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 522

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: BSD 3-Clause "New" or "Revised" License (Valid open source OSI approved license)

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- None

MISSING DOIs

- No DOI given, and none found for title: Bokeh: an interactive visualization library for mo...
- 10.1126/scisignal.2004088 may be a valid DOI for title: Integrative analysis of complex cancer genomics an...
- 10.7287/peerj.preprints.26441v1 may be a valid DOI for title: DataScope: Interactive visual exploratory dashboar...
- 10.1038/s41598-020-60981-9 may be a valid DOI for title: NBIA: a network-based integrative analysis framewo...
- 10.1007/s10278-013-9622-7 may be a valid DOI for title: The Cancer Imaging Archive (TCIA): Maintaining and...
- 10.1200/cci.20.00001 may be a valid DOI for title: PRISM: A Platform for Imaging in Precision Medicin...

INVALID DOIs

- None

@birm
Copy link

birm commented Apr 30, 2024

I think we've fixed the dois! Not sure if Bokeh has a preferred citation though.

@birm
Copy link

birm commented May 3, 2024

@editorialbot commands

@editorialbot
Copy link
Collaborator Author

Hello @birm, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for branch
@editorialbot set joss-paper as branch

# Run checks and provide information on the repository and the paper file
@editorialbot check repository

# Check the references of the paper for missing DOIs
@editorialbot check references

# Generates the pdf paper
@editorialbot generate pdf

# Generates a LaTeX preprint file
@editorialbot generate preprint

# Get a link to the complete list of reviewers
@editorialbot list reviewers

@birm
Copy link

birm commented May 3, 2024

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1126/scisignal.2004088 is OK
- 10.1109/VAHC.2017.8387496 is OK
- 10.1038/s41598-020-60981-9 is OK
- 10.1007/s10278-013-9622-7 is OK
- 10.1200/cci.20.00001 is OK

MISSING DOIs

- No DOI given, and none found for title: Bokeh: an interactive visualization library for mo...

INVALID DOIs

- None

@birm
Copy link

birm commented May 10, 2024

Based on the interests on the reviewer form, I think Ian Hunt-Isaak and Allie Tatarian would be good reviewers for this paper.

@Kevin-Mattheus-Moerman
Copy link
Member

@birm thanks for those suggestions. I am currently checking if this work is in scope for JOSS, and if so, will be looking for a handling editor shortly.

In the mean time, can you help clarify if it would be correct to say that the JavaScript for this submission forms the main code achievement here? Secondly, could you clarify if the JavaScript is fully your original work, or if some default (e.g. GUI related) codes were imported or if code was autogenerated. Thanks.

@Kevin-Mattheus-Moerman
Copy link
Member

@birm 👋

@birm
Copy link

birm commented May 29, 2024

Sorry for the delay. The code is the accomplishment. It uses react, but it's otherwise the contrubutors' work. The only part which is autogenerated is in ./dist/, which we prebuild for the demo site (https://sharmalab.github.io/eaglescope/) and other deployments where we don't have something to bundle the code.

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot invite @csoneson as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@csoneson
Copy link
Member

@editorialbot assign @csoneson as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @csoneson is now the editor

@csoneson
Copy link
Member

👋🏻 @birm I will handle your submission and will start by finding two suitable reviewers. Thank you for the suggestions above.

@csoneson
Copy link
Member

👋🏻 @ianhi, @allie-tatarian - would you be interested in reviewing this submission for JOSS?

Eaglescope: an interactive visualization and cohort selection tool for biomedical data exploration
#6700

Thanks in advance!

@allie-tatarian
Copy link

Hi @csoneson, thanks for reaching out! I actually can't get this software to run on my machine at all - I think it might be a security issue (this has happened to me before). I've attached the error log in case it's useful to the developers (@birm), but I'm going to let someone else review this one.
2024-05-31T16_28_22_532Z-debug-0.log

@birm
Copy link

birm commented May 31, 2024

@allie-tatarian Thank you for the log! I think we fixed that dependency just now. Even if you can't review, would you be able to try running it again to see if this has resolved your issue. Your help is appreciated either way!

@allie-tatarian
Copy link

@birm thanks - looks like it is working now!

@csoneson
Copy link
Member

csoneson commented Jun 4, 2024

👋🏻 @flekschas, @sebastian-raubach - would you be interested in reviewing this submission for JOSS?

Eaglescope: an interactive visualization and cohort selection tool for biomedical data exploration
#6700

Thanks in advance!

@csoneson
Copy link
Member

csoneson commented Jun 4, 2024

Hi @allie-tatarian - thanks for your quick response (and the error log 🙂).

@flekschas
Copy link

@csoneson Happy to review it!

@csoneson
Copy link
Member

csoneson commented Jun 4, 2024

@flekschas Thank you! I will assign you, and as soon as we have secured one more reviewer I will open the actual review issue where you will be able to generate your review checklist.

@csoneson
Copy link
Member

csoneson commented Jun 4, 2024

@editorialbot add @flekschas as reviewer

@editorialbot
Copy link
Collaborator Author

@flekschas added to the reviewers list!

@sebastian-raubach
Copy link

👋🏻 @flekschas, @sebastian-raubach - would you be interested in reviewing this submission for JOSS?

Eaglescope: an interactive visualization and cohort selection tool for biomedical data exploration
#6700

Thanks in advance!

Yeah, I can give it a go.

@csoneson
Copy link
Member

csoneson commented Jun 4, 2024

Awesome, thank you @sebastian-raubach!

@csoneson
Copy link
Member

csoneson commented Jun 4, 2024

@editorialbot add @sebastian-raubach as reviewer

@editorialbot
Copy link
Collaborator Author

@sebastian-raubach added to the reviewers list!

@csoneson
Copy link
Member

csoneson commented Jun 4, 2024

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #6837.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS HTML JavaScript pre-review Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials
Projects
None yet
Development

No branches or pull requests

7 participants