Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: FastVPINNs: An efficient tensor-based Python library for solving partial differential equations using hp-Variational Physics Informed Neural Networks #6761

Closed
editorialbot opened this issue May 17, 2024 · 37 comments
Assignees
Labels
pre-review Python TeX Track: 7 (CSISM) Computer science, Information Science, and Mathematics

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented May 17, 2024

Submitting author: @thivinanandh (Thivin Anandh)
Repository: https://github.com/cmgcds/fastvpinns
Branch with paper.md (empty if default branch): joss_paper
Version: v1.0.1
Editor: @diehlpk
Reviewers: @pescap, @ziyiyin97
Managing EiC: Daniel S. Katz

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/173453d08813f66a718f583502351747"><img src="https://joss.theoj.org/papers/173453d08813f66a718f583502351747/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/173453d08813f66a718f583502351747/status.svg)](https://joss.theoj.org/papers/173453d08813f66a718f583502351747)

Author instructions

Thanks for submitting your paper to JOSS @thivinanandh. Currently, there isn't a JOSS editor assigned to your paper.

@thivinanandh if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 7 (CSISM) Computer science, Information Science, and Mathematics labels May 17, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.16 s (1039.9 files/s, 271934.7 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
CSV                              2              0              0          16044
Python                          71           2557           4087           7694
Markdown                        19           1038              0           3710
reStructuredText                46           1580           2332           2181
YAML                            20            162             18            696
XML                              1              5              0            563
TeX                              1              5              0             94
TOML                             1              4              0             58
DOS Batch                        1              8              1             26
make                             1              4              7              9
INI                              1              0              0              3
-------------------------------------------------------------------------------
SUM:                           164           5363           6445          31078
-------------------------------------------------------------------------------

Commit count by author:

    84	thivin
    15	divijghose
     6	Thivin Anandh
     3	Rithika Chidambaram
     1	Divij
     1	Prof. Sashikumaar Ganesan

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 1637

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: MIT License (Valid open source OSI approved license)

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- None

MISSING DOIs

- 10.1016/j.jcp.2018.10.045 may be a valid DOI for title: Physics-informed neural networks: A deep learning ...
- No DOI given, and none found for title: hp-VPINNs: High-Performance Variational Physics-In...
- No DOI given, and none found for title: FastVPINNs: Tensor-Driven Acceleration of VPINNs f...
- 10.1016/j.cma.2020.113547 may be a valid DOI for title: hp-VPINNs: Variational physics-informed neural net...
- No DOI given, and none found for title: Variational physics-informed neural networks for s...
- No DOI given, and none found for title:  TensorFlow: Large-Scale Machine Learning on Heter...
- No DOI given, and none found for title: Finite elements: Theory and algorithms

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@danielskatz
Copy link

👋 @thivinanandh - Thanks for your submission. I'll now look for an editor.

While I do this, you could work on the possibly missing DOIs that editorialbot suggests, but note that some may be incorrect. Please feel free to make changes to your .bib file, then use the command @editorialbot check references to check again, and the command @editorialbot generate pdf when the references are right to make a new PDF. editorialbot commands need to be the first entry in a new comment.

@danielskatz
Copy link

@diehlpk - do you think you could edit this submission?

@danielskatz
Copy link

@editorialbot invite @diehlpk as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@diehlpk
Copy link
Member

diehlpk commented May 17, 2024

@editorialbot assign @diehlpk as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @diehlpk is now the editor

@diehlpk
Copy link
Member

diehlpk commented May 17, 2024

Hi @thivinanandh could you please recommend some reviewers?

@danielskatz
Copy link

Please see the first comment in this issue for more on how to do so.

@diehlpk
Copy link
Member

diehlpk commented May 17, 2024

Hi @Coral-orca do you have time to review this paper?

@diehlpk
Copy link
Member

diehlpk commented May 17, 2024

Hi @ziyiyin97 do you have time to review this paper?

@ziyiyin97
Copy link

Yes, I'be happy to.

@thivinanandh
Copy link

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- None

MISSING DOIs

- 10.1016/j.jcp.2018.10.045 may be a valid DOI for title: Physics-informed neural networks: A deep learning ...
- No DOI given, and none found for title: hp-VPINNs: High-Performance Variational Physics-In...
- No DOI given, and none found for title: FastVPINNs: Tensor-Driven Acceleration of VPINNs f...
- 10.1016/j.cma.2020.113547 may be a valid DOI for title: hp-VPINNs: Variational physics-informed neural net...
- No DOI given, and none found for title: Variational physics-informed neural networks for s...
- No DOI given, and none found for title:  TensorFlow: Large-Scale Machine Learning on Heter...
- No DOI given, and none found for title: Finite elements: Theory and algorithms

INVALID DOIs

- None

@thivinanandh
Copy link

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- None

MISSING DOIs

- No DOI given, and none found for title: hp-VPINNs: High-Performance Variational Physics-In...

INVALID DOIs

- https://doi.org/10.1016/j.jcp.2018.10.045 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.48550/arXiv.2404.12063 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1016/j.cma.2020.113547 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.48550/arXiv.1912.00873 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.48550/arXiv.1603.04467 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1017/9781108235013 is INVALID because of 'https://doi.org/' prefix

@thivinanandh
Copy link

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.jcp.2018.10.045 is OK
- 10.48550/arXiv.2404.12063 is OK
- 10.1016/j.cma.2020.113547 is OK
- 10.48550/arXiv.1912.00873 is OK
- 10.48550/arXiv.1603.04467 is OK
- 10.1017/9781108235013 is OK

MISSING DOIs

- No DOI given, and none found for title: hp-VPINNs: High-Performance Variational Physics-In...

INVALID DOIs

- None

@thivinanandh
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@thivinanandh
Copy link

@danielskatz , Sorry for the delay in response. I have fixed the DOI errors by adding DOI references to the bib file. The one error comes from the bib item which refers to the hp-VPINNs github repository, which does not have any DOI.

@thivinanandh
Copy link

@danielskatz , could you kindly invite @ziyiyin97 as reviewer, since he has agreed to review the paper.
Please let me know if you need any additional information from myside.

@danielskatz
Copy link

@thivinanandh - @diehlpk is the editor who will invite and add reviewers. As track editor, I'm done for now, unless any problems arise where @diehlpk asks for help, and until we get to the end of the process, where I'll come back for final processing.

@divijghose
Copy link

Hello @diehlpk,
We have gone through the list of reviewers and identified the following potential reviewers:

  1. @levimcclenny
  2. @holl-
  3. @pescap

This is in addition to @ziyiyin97 who has already agreed to review.
If you need any more information, please let us know.

@pescap
Copy link

pescap commented May 18, 2024

Happy to review it.

@divijghose
Copy link

Hello @diehlpk ,
It looks like @ziyiyin97 and @pescap have agreed to review the paper. Could you kindly invite and add them as reviewers?
Thank you!

@diehlpk
Copy link
Member

diehlpk commented May 19, 2024

@editorialbot add @pescap as reviewer

@editorialbot
Copy link
Collaborator Author

@pescap added to the reviewers list!

@diehlpk
Copy link
Member

diehlpk commented May 19, 2024

@editorialbot add @ziyiyin97 as reviewer

@editorialbot
Copy link
Collaborator Author

@ziyiyin97 added to the reviewers list!

@diehlpk
Copy link
Member

diehlpk commented May 19, 2024

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #6764.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-review Python TeX Track: 7 (CSISM) Computer science, Information Science, and Mathematics
Projects
None yet
Development

No branches or pull requests

7 participants