[REVIEW]: Async Modules Supporting ES5 & ES6 with Control Flow

[whedon]

Submitting author: @IbrahimTanyalcin (Ibrahim Tanyalcin)
Repository: https://github.com/IbrahimTanyalcin/taskq
Version: v2.1.4
Editor: @arfon
Reviewer: @xirdneh
Archive: Pending

Status

Status badge code:

HTML: <a href="http://joss.theoj.org/papers/864b66eb13ca2c0dc83f22400ae7ce25"><img src="http://joss.theoj.org/papers/864b66eb13ca2c0dc83f22400ae7ce25/status.svg"></a>
Markdown: [![status](http://joss.theoj.org/papers/864b66eb13ca2c0dc83f22400ae7ce25/status.svg)](http://joss.theoj.org/papers/864b66eb13ca2c0dc83f22400ae7ce25)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@xirdneh, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:

1. Make sure you're logged in to your GitHub account
2. Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations

The reviewer guidelines are available here: https://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @arfon know.

Review checklist for @xirdneh

Conflict of interest

• As the reviewer I confirm that I have read the JOSS conflict of interest policy and that there are no conflicts of interest for me to review this work.

Code of Conduct

• I confirm that I read and will adhere to the JOSS code of conduct.

General checks

• Repository: Is the source code for this software available at the repository url?
• License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
• Version: Does the release version given match the GitHub release (v2.1.4)?
• Authorship: Has the submitting author (@IbrahimTanyalcin) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?

Functionality

• Installation: Does installation proceed as outlined in the documentation?
• Functionality: Have the functional claims of the software been confirmed?
• Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

• A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
• Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
• Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
• Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
• Automated tests: Are there automated tests or manual steps described so that the function of the software can be verified?
• Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

• Authors: Does the paper.md file include a list of authors with their affiliations?
• A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
• References: Do all archival references that should have a DOI list one (e.g., papers, datasets, software)?

[whedon]

Hello human, I'm @whedon. I'm here to help you with some common editorial tasks. @xirdneh it looks like you're currently assigned as the reviewer for this paper 🎉.

⭐ Important ⭐

If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿

To fix this do the following two things:

1. Set yourself as 'Not watching' https://github.com/openjournals/joss-reviews:

2. You may also like to change your default settings for this watching repositories in your GitHub profile here: https://github.com/settings/notifications

For a list of things I can do to help you, just type:

@whedon commands

[whedon]

Attempting PDF compilation. Reticulating splines etc...

[whedon]

PDF failed to compile for issue #780 with the following error:

% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed

0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
100 16 0 16 0 0 178 0 --:--:-- --:--:-- --:--:-- 179
Error producing PDF.
! Misplaced alignment tab character &.
\f@nch@olf ...018). Async Modules Supporting ES5 &
ES6 with Control Flow. \t...
l.242 \end{document}

Looks like we failed to compile the PDF

[IbrahimTanyalcin]

Is it because of the white spaces/- in the paper.md ?

[arfon]

Is it because of the white spaces/- in the paper.md ?

Looks like this is because of the & in the title. I can't seem to figure out how to get Pandoc to escape it properly. A quick fix would be to change & to and.

[IbrahimTanyalcin]

I guess & would work. Let's give it a try, I'll push paper.md again

[IbrahimTanyalcin]

Updated.

[arfon]

@whedon generate pdf

[whedon]

Attempting PDF compilation. Reticulating splines etc...

[whedon]

PDF failed to compile for issue #780 with the following error:

% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed

0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
100 16 0 16 0 0 351 0 --:--:-- --:--:-- --:--:-- 355
Error producing PDF.
! Misplaced alignment tab character &.
\f@nch@olf ...018). Async Modules Supporting ES5 &
amp; ES6 with Control Flow...
l.242 \end{document}

Looks like we failed to compile the PDF

[IbrahimTanyalcin]

Oww, I yield, 🤦‍♂️ I will replace with and.

[IbrahimTanyalcin]

Done!

[arfon]

@whedon generate pdf

[whedon]

Attempting PDF compilation. Reticulating splines etc...

[whedon]

--> Check article proof 📄 <--

[IbrahimTanyalcin]

Hi @arfon,
@xirdneh

Is there anything I should do?

[arfon]

Hi @xirdneh - when do you think you might be able to complete your review by?

[arfon]

I just contacted @xirdneh by email.

[arfon]

Over the past 8 weeks I've contacted @IbrahimTanyalcin multiple times over email. Unfortunately both our reviewer and author are unreachable.

Given the major challenges we had finding a reviewer for this submission, I'm going to withdraw this submission on behalf of the submitting author.