Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: AtomNeb: Atomic Data for Ionized Nebulae #799

Closed
whedon opened this issue Jun 30, 2018 · 40 comments
Closed

[PRE REVIEW]: AtomNeb: Atomic Data for Ionized Nebulae #799

whedon opened this issue Jun 30, 2018 · 40 comments

Comments

@whedon
Copy link

whedon commented Jun 30, 2018

Submitting author: @danehkar (Ashkbiz Danehkar)
Repository: https://github.com/atomneb/AtomNeb-idl
Version: v0.0.1
Editor: @arfon
Reviewers: @mgalloy, @mdpiper

Author instructions

Thanks for submitting your paper to JOSS @danehkar. The JOSS editor (shown at the top of this issue) will work with you on this issue to find a reviewer for your submission before creating the main review issue.

@danehkar if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Jun 30, 2018

Hello human, I'm @whedon. I'm here to help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

@whedon
Copy link
Author

whedon commented Jun 30, 2018

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Jun 30, 2018

@danehkar
Copy link

danehkar commented Jul 1, 2018

Based on your list of joss reviewers, I think that @mgalloy @scivision @mankoff would be great reviewers for IDL programs.

@arfon
Copy link
Member

arfon commented Aug 4, 2018

@whedon assign @arfon as editor

@whedon
Copy link
Author

whedon commented Aug 4, 2018

OK, the editor is @arfon

@arfon
Copy link
Member

arfon commented Aug 4, 2018

@mgalloy @scivision @mankoff - would one or more of you be willing to review this submission for JOSS?

@mgalloy
Copy link

mgalloy commented Aug 6, 2018

I can review this.

@arfon
Copy link
Member

arfon commented Aug 7, 2018

I can review this.

Great, thanks @mgalloy! I'd like to find two reviewers for this submission if possible so if you could just sit tight for another few days that would be great. Once we have a second reviewer, I'll open up the main review issue.

@danehkar
Copy link

danehkar commented Aug 8, 2018

Your list of joss reviewers also shows that @manodeep @mattpitkin @zingale @ziotom78 @benjaminrose @Cadair @nespinoza are comfortable with reviewing topic areas of astronomy and astrophysics.

@danehkar
Copy link

danehkar commented Aug 9, 2018

@arfon I corrected minor typo mistakes. Please regenerate the article PDF after assigning 2 reviewers.

@zingale
Copy link

zingale commented Aug 9, 2018

I'm not really an IDL person anymore, and don't have IDL to test it, so I don't think I can review

@ziotom78
Copy link

ziotom78 commented Aug 10, 2018 via email

@manodeep
Copy link

Same situation for me - have not written/used IDL in 3+ years

@nespinoza
Copy link

Same here! Dropped IDL at least 7+ years ago. Sorry!

@arfon
Copy link
Member

arfon commented Aug 10, 2018

@danehkar as with your other submission, I think it might be tough to find IDL reviewers these days. Please feel free to suggest potential reviewers from places other than the list I shared earlier.

@danehkar
Copy link

It might work on GNU Data Language (GDL). As my library depends on IDL Astronomy User's library, I cannot fix any GDL-incompatibility bugs related to IDL Astronomy User's library. I am also preparing a Python version of these package (AtomNeb + proEQUIB). However, I will release them next year. Most people who work at US research institutes have IDL license on their computers. For example, @wlandsman who works on IDL Astronomy User's library, IDLAstro, might be able to test my IDL libraries (AtomNeb and proEQUIB), or @flamingbear who works on Coyote IDL Library.

@wlandsman
Copy link

wlandsman commented Aug 10, 2018 via email

@danehkar
Copy link

@wlandsman Please also look at [PRE REVIEW]: proEQUIB. proEQUIB IDL library uses the AtomNeb APIs. There are some examples.

@danehkar
Copy link

danehkar commented Aug 10, 2018

@wlandsman if you are able to review and test this IDL library, please let @arfon know as soon as possible since he is looking for 2 reviewers for this submission in JOSS. Currently, he found one reviewer.

@mgalloy
Copy link

mgalloy commented Aug 15, 2018

@mdpiper would be a good IDL reviewer. I believe he has started the process to be a reviewer.

@arfon
Copy link
Member

arfon commented Aug 16, 2018

Hi @mgalloy & @wlandsman, firstly, many thanks for your help/interest in these packages thus far.

We've recently had two submissions from @danehkar: this one, and the proEQUIB IDL library.

I'm wondering if you'd be both willing to review both of these packages? I ask as we're really struggling to find suitable reviewers for these packages.

If this is something that you'd be open to then I would go ahead and start the reviews for both but there would be no expectation on our part that you complete these both simultaneously!

What do you both think?

@mgalloy
Copy link

mgalloy commented Aug 17, 2018

I can review both of the packages.

@mdpiper
Copy link

mdpiper commented Aug 17, 2018 via email

@arfon
Copy link
Member

arfon commented Aug 17, 2018

@whedon add @mgalloy as reviewer

@whedon
Copy link
Author

whedon commented Aug 17, 2018

OK, @mgalloy is now a reviewer

@arfon
Copy link
Member

arfon commented Aug 17, 2018

@whedon add @mdpiper as reviewer

@whedon whedon unassigned arfon and mgalloy Aug 17, 2018
@whedon
Copy link
Author

whedon commented Aug 17, 2018

OK, @mdpiper is now a reviewer

@arfon
Copy link
Member

arfon commented Aug 17, 2018

@whedon start review

@whedon
Copy link
Author

whedon commented Aug 17, 2018

OK, I've started the review over in #898. Feel free to close this issue now!

@arfon
Copy link
Member

arfon commented Aug 17, 2018

@mgalloy, @mdpiper - thanks so much for agreeing to review these packages! I've gone ahead and started the review for this submission and will do the same for #798.

@danehkar - given you have the same reviewers for both of these packages - do you have a preference for which package @mgalloy & @mdpiper review first?

@arfon arfon closed this as completed Aug 17, 2018
@danehkar
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Feb 27, 2019

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Feb 27, 2019

@danehkar
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Feb 27, 2019

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Feb 27, 2019

@danehkar
Copy link

danehkar commented Mar 6, 2019

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Mar 6, 2019

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Mar 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants