New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: AtomNeb: IDL Library for Atomic Data of Ionized Nebulae #898
Comments
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @mgalloy, it looks like you're currently assigned as the reviewer for this paper 🎉. ⭐ Important ⭐ If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿 To fix this do the following two things:
For a list of things I can do to help you, just type:
|
|
Info for contributors (the last item in the Documentation checklist) isn't present, so I made a request in atomneb/AtomNeb-idl#1. |
This package doesn't include unit tests (second-to-last item in the Documentation checklist). I've made a request for testing with atomneb/AtomNeb-idl#2. |
The package isn't stamped with a release, so I created atomneb/AtomNeb-idl#3 to request one. This addresses the third item in the General checks checklist. |
The package doesn't include API documentation (the fourth item in the Documentation checklist). I've requested this in atomneb/AtomNeb-idl#4. |
I offered a PR (atomneb/AtomNeb-idl#5) to automatically locate the package data from the examples. |
Created an issue (atomneb/AtomNeb-idl#6) to address package installation (the first item in the Functionality checklist). |
@mdpiper thank you for your review. I will solve those minor issues. did you also finish your review of proEQUIB? |
Catching up after some travel. Added some comments on issues opened by @mdpiper. I think it would also be useful to add a short sentence after the opening description of AtomNeb database in your README that indicates precisely how I should be able to start looking at proEQUIB shortly. |
@danehkar - I think this review is waiting on you at this point? |
I included CONTRIBUTING.md in the AtomNeb-idl repository that contains some guidelines for contributors. Now I closed the issue atomneb/AtomNeb-idl#1. |
Thank you! I merged your PR into the repository. Now the package data are automatically located in the examples: atomneb/AtomNeb-idl/examples. |
Thank you for your installation note suggestion. I added an installation note in README.md:
Now I closed the issue atomneb/AtomNeb-idl#6. |
@danehkar With your recent updates, I've marked as complete a few more items on the checklist. |
👋 @danehkar — We haven't heard from you in a while. What's your status? Are you able to work on this revision soon? |
@labarba I am currently working on those issues. Hopefully, I will resolve them in a month. Thank you for your patience. |
@mdpiper The documentation is now hosted at https://atomneb.github.io/AtomNeb-idl/doc/ |
@mdpiper I added mgunit in the folder test_mgunit for automated tests. To test, you can download AtomNeb-idl with its dependencies as follows
You need to unpack rc_o_iii_SSB17.fits.tar.gz in
To run the test, you need to run the following command:
There should not be any errors in |
I ran the tests and confirm they all passed. One note: I had to go get |
Thank you for testing. I will copy |
@arfon I would like to rename the title of this submission (898) from AtomNeb: Atomic Data for Ionized Nebulae to AtomNeb: IDL Library for Atomic Data of Ionized Nebulae since I am working on a similar python package, and I want to distinguish between them. I will upload the revised paper of this IDL library soon. |
OK, no problem. I've updated the issue title here. |
Considering Semantic Versioning (MAJOR.MINOR.PATCH), the code did not have any MAJOR change such as incompatible API changes, and any MINOR changes (e.g. adding a new functionality) since it was submitted. It has some changes in comments for documentation, so I changed the PATCH version from v0.0.1 to v0.0.2. I added an MGUnit tester, while the program functions were not changed, so there are no major or minor changes. @arfon Please update Version from v0.0.1 to v0.0.2. |
@whedon set v0.0.2 as version |
OK. v0.0.2 is the version. |
@whedon generate pdf |
|
@danehkar - At this point could you make an archive of the reviewed software in Zenodo/figshare/other service and update this thread with the DOI of the archive? I can then move forward with accepting the submission. |
@arfon I did the proof correction in the paper. You can check it here: 799. Please regenerated the final pdf for the paper. I also made an archive of the reviewed software in Zenodo here: https://doi.org/10.5281/zenodo.2584420 |
@whedon generate pdf |
|
@whedon set 10.5281/zenodo.2584420 as archive |
OK. 10.5281/zenodo.2584420 is the archive. |
@whedon accept |
|
Check final proof 👉 openjournals/joss-papers#539 If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#539, then you can now move forward with accepting the submission by compiling again with the flag
|
|
@danehkar - could you check those potentially missing DOIs and see if they are the correct ones for some of your references? |
@arfon Those references with missing DOI are from Astronomy & Astrophysics and Astronomy and Astrophysics Supplement: Those DOI identified by the robot whedon are NOT related to these 3 references:
I confirm that the references in |
@whedon accept deposit=true |
|
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? notify your editorial technical team... |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @danehkar (Ashkbiz Danehkar)
Repository: https://github.com/atomneb/AtomNeb-idl
Version: v0.0.2
Editor: @arfon
Reviewer: @mgalloy, @mdpiper
Archive: 10.5281/zenodo.2584420
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@mgalloy & @mdpiper, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @arfon know.
✨ Please try and complete your review in the next two weeks ✨
Review checklist for @mgalloy
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
paper.md
file include a list of authors with their affiliations?Review checklist for @mdpiper
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
paper.md
file include a list of authors with their affiliations?The text was updated successfully, but these errors were encountered: