Refactor ToC specs

app/views/toc/current_issue.html.erb

@@ -1,4 +1,4 @@
-<div class="container">
+<div class="container" id="toc-header">
   <div class="welcome"><%= link_to "Table of Contents", toc_index_path %> Current issue</div>
   <div class="hero-small">
     <div class="hero-title">

app/views/toc/index.html.erb

@@ -1,4 +1,4 @@
-<div class="container">
+<div class="container" id="toc-header">
   <div class="welcome">All volumes and issues</div>
   <div class="hero-small">
     <div class="hero-title">

app/views/toc/issue.html.erb

@@ -1,4 +1,4 @@
-<div class="container">
+<div class="container" id="toc-header">
   <div class="welcome"><%= link_to "Table of Contents", toc_index_path %> <%= Date::MONTHNAMES[@month] %> <%= @year %> Volume <%= @volume %></div>
   <div class="hero-small">
     <div class="hero-title">

app/views/toc/volume.html.erb

@@ -1,4 +1,4 @@
-<div class="container">
+<div class="container" id="toc-header">
   <div class="welcome"><%= link_to "Table of Contents", toc_index_path %> <%= "Year " + @year.to_s if @year %></div>
   <div class="hero-small">
     <div class="hero-title">

app/views/toc/year.html.erb

@@ -1,4 +1,4 @@
-<div class="container">
+<div class="container" id="toc-header">
   <div class="welcome"><%= link_to "Table of Contents", toc_index_path %></div>
   <div class="hero-small">
     <div class="hero-title">

spec/system/toc_spec.rb

@@ -44,8 +44,10 @@
   scenario "index" do
     visit toc_index_path
 
-    expect(page).to have_content("Table of Contents")
-    expect(page).to_not have_link("Table of Contents")
+    within("#toc-header") do
+      expect(page).to have_content("Table of Contents")
+      expect(page).to_not have_link("Table of Contents")
+    end
 
     @volumes.each do |volume|
       expect(page).to have_link("Volume #{volume} (#{@years[@volumes.index(volume)]})", href: toc_volume_path(volume: volume))
@@ -60,51 +62,63 @@
 
   scenario "by year" do
     visit toc_year_path(year: @years.first)
-    expect(page).to have_content("Year #{@years.first}")
-    expect(page).to have_link("Table of Contents")
+    within("#toc-header") do
+      expect(page).to have_content("Year #{@years.first}")
+      expect(page).to have_link("Table of Contents")
+    end
     expect(page).to have_link(@first_accepted_paper.title, href: @first_accepted_paper.seo_url)
     expect(page).to_not have_link(@retracted_paper.title)
     expect(page).to_not have_link(@last_accepted_paper.title)
 
     visit toc_year_path(year: @years.last)
-    expect(page).to have_content("Year #{@years.last}")
-    expect(page).to have_link("Table of Contents")
+    within("#toc-header") do
+      expect(page).to have_content("Year #{@years.last}")
+      expect(page).to have_link("Table of Contents")
+    end
     expect(page).to have_link(@retracted_paper.title, href: @retracted_paper.seo_url)
     expect(page).to have_link(@last_accepted_paper.title, href: @last_accepted_paper.seo_url)
     expect(page).to_not have_link(@first_accepted_paper.title)
   end
 
   scenario "by volume" do
     visit toc_volume_path(volume: 1)
-    expect(page).to have_content("Year #{@years.first}")
-    expect(page).to have_content("Volume 1")
-    expect(page).to have_link("Table of Contents")
+    within("#toc-header") do
+      expect(page).to have_content("Year #{@years.first}")
+      expect(page).to have_content("Volume 1")
+      expect(page).to have_link("Table of Contents")
+    end
     expect(page).to have_link(@first_accepted_paper.title, href: @first_accepted_paper.seo_url)
     expect(page).to_not have_link(@retracted_paper.title)
     expect(page).to_not have_link(@last_accepted_paper.title)
 
     visit toc_volume_path(volume: @volumes.last)
-    expect(page).to have_content("Year #{@years.last}")
-    expect(page).to have_content("Volume #{@volumes.last}")
-    expect(page).to have_link("Table of Contents")
+    within("#toc-header") do
+      expect(page).to have_content("Year #{@years.last}")
+      expect(page).to have_content("Volume #{@volumes.last}")
+      expect(page).to have_link("Table of Contents")
+    end
     expect(page).to have_link(@retracted_paper.title, href: @retracted_paper.seo_url)
     expect(page).to have_link(@last_accepted_paper.title, href: @last_accepted_paper.seo_url)
     expect(page).to_not have_link(@first_accepted_paper.title)
   end
 
   scenario "by issue" do
     visit toc_issue_path(issue: 1)
-    expect(page).to have_content("#{Date::MONTHNAMES[@launch_month]} #{@years.first} Volume 1")
-    expect(page).to have_content("Issue 1")
-    expect(page).to have_link("Table of Contents")
+    within("#toc-header") do
+      expect(page).to have_content("#{Date::MONTHNAMES[@launch_month]} #{@years.first} Volume 1")
+      expect(page).to have_content("Issue 1")
+      expect(page).to have_link("Table of Contents")
+    end
     expect(page).to have_link(@first_accepted_paper.title, href: @first_accepted_paper.seo_url)
     expect(page).to_not have_link(@retracted_paper.title)
     expect(page).to_not have_link(@last_accepted_paper.title)
 
     visit toc_issue_path(issue: @issues.last)
-    expect(page).to have_content("#{Date::MONTHNAMES[@now.month]} #{@years.last} Volume #{@volumes.last}")
-    expect(page).to have_content("Issue #{@issues.last}")
-    expect(page).to have_link("Table of Contents")
+    within("#toc-header") do
+      expect(page).to have_content("#{Date::MONTHNAMES[@now.month]} #{@years.last} Volume #{@volumes.last}")
+      expect(page).to have_content("Issue #{@issues.last}")
+      expect(page).to have_link("Table of Contents")
+    end
     expect(page).to have_link(@retracted_paper.title, href: @retracted_paper.seo_url)
     expect(page).to have_link(@last_accepted_paper.title, href: @last_accepted_paper.seo_url)
     expect(page).to_not have_link(@first_accepted_paper.title)
@@ -118,9 +132,11 @@
 
   scenario "current issue" do
     visit toc_current_issue_path
-    expect(page).to have_content("Current issue")
-    expect(page).to have_content("Year #{@years.last} Volume #{@volumes.last} Issue #{@issues.last}")
-    expect(page).to have_link("Table of Contents")
+    within("#toc-header") do
+      expect(page).to have_content("Current issue")
+      expect(page).to have_content("Year #{@years.last} Volume #{@volumes.last} Issue #{@issues.last}")
+      expect(page).to have_link("Table of Contents")
+    end
     expect(page).to have_link(@retracted_paper.title, href: @retracted_paper.seo_url)
     expect(page).to have_link(@last_accepted_paper.title, href: @last_accepted_paper.seo_url)
     expect(page).to_not have_link(@first_accepted_paper.title)