Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch recommonmark to myst #1321

Merged
merged 5 commits into from
Mar 13, 2024
Merged

Switch recommonmark to myst #1321

merged 5 commits into from
Mar 13, 2024

Conversation

sneakers-the-rat
Copy link
Contributor

recommonmark says to use myst instead, and is deprecated since 2021. I think it's maybe not the best thing for a FOSS journal to be modeling using deprecated software in its docs ;) (no shade, i get how this is a low maintenance priority)

Not a huge switch - just swapping out (almost) all the eval_rst bits with myst directives, and fixing up some of the cross references that were within the rst blocks :)

myst is great! we love myst <3.

@sneakers-the-rat sneakers-the-rat added the enhancement:meta General improvements to JOSS label Mar 12, 2024
Copy link
Member

@xuanxu xuanxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Niiiice!

docs/submitting.md Outdated Show resolved Hide resolved
@xuanxu xuanxu merged commit a3239fa into openjournals:main Mar 13, 2024
1 check passed
@xuanxu
Copy link
Member

xuanxu commented Mar 13, 2024

Thanks @sneakers-the-rat!

@rowanc1
Copy link

rowanc1 commented Mar 13, 2024

Glad this was a relatively easy switch over!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement:meta General improvements to JOSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants