Generalizing JOSS #361
Generalizing JOSS #361
Conversation
This also adds .ruby-version and .ruby-gemset, pry-byebug, and dotenv.
This is to support multiple review checklists by submission type
| <%- if paper.kind.present? %> | ||
| <%= render partial: "content/github/#{paper.kind}_review_checklist", locals: local_assigns %> | ||
| <%- else %> | ||
| <%= render partial: "content/github/review_checklist", locals: local_assigns %> |
There was a problem hiding this comment.
Does local_assigns make the paper variable available to the partial at content/github/review_checklist @parrish?
There was a problem hiding this comment.
Yep, it's basically a passthrough for the locals that used to render shared/review_body
| STR | ||
| ) | ||
|
|
||
| Editor.create( |
There was a problem hiding this comment.
Shouldn't these all be kind: topic?
There was a problem hiding this comment.
Yeah, it's the column default, but there's no harm in being explicit here.
| <%= f.text_field :last_name %> | ||
| </div> | ||
| <div class="field"> | ||
| <%= f.label :login %><br> |
There was a problem hiding this comment.
I'm wondering if this should be a select based on Repository.editors
|
Hi @arfon — when do you estimate that this PR might be merged in? |
Upgrade to Rails 5.1
| @@ -1,6 +1,6 @@ | |||
| class SessionsController < ApplicationController | |||
| def create | |||
| user = User.from_omniauth(env["omniauth.auth"]) | |||
| user = User.from_omniauth(ENV["omniauth.auth"]) | |||
👋 @labarba @kyleniemeyer - we're getting really close. I've been testing all of these changes over the last couple of days and things are looking pretty solid. I hope to finish up this testing this week. |
|
Are we there yet? |
db/seeds.rb
Outdated
| last_name: "Githinji", | ||
| login: "biorelated", | ||
| email: "", | ||
| avatar_url: "http://joss.theoj.org/assets/editors/george-d24f98577bcc40a745b81f7ee5c4b6a3e5f150b563f940cb792ba92f88ed6483.jpg", |
There was a problem hiding this comment.
@parrish - what should we do about URLs like this? How does encoding the asset pipeline stuff (i.e. george-d24f98577bcc40a745b81f7ee5c4b6a3e5f150b563f940cb792ba92f88ed6483.png work in the long run?
There was a problem hiding this comment.
I guess perhaps it doesn't matter as long as the file doesn't change? http://guides.rubyonrails.org/asset_pipeline.html#what-is-fingerprinting-and-why-should-i-care-questionmark
I think so yes. I'm planning on migrating the JOSS site over to this updated code later today and once that's done I think we're ready to start rolling out the new JOSE codebase. |
👋 @parrish. I've moved this PR over to a branch on the parent repository so I can push updates to it too. Copying in your PR body from #353 here:
This looks like a larger PR than it really is since there's a fair bit of template reworking. It's probably fairly digestable per-commit, though I'm happy to split this out into multiple PR's if it's easier.
Motivated by #329, this PR
Along with openjournals/whedon-api#11, this should get us into a pretty good position to have multiple journals running. 🎉
In-progress deploys are going to http://staging.joss.theoj.org
Feedback welcome!