Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize JOSS to better handle multiple instances #353

Closed
wants to merge 7 commits into from

Conversation

parrish
Copy link
Collaborator

@parrish parrish commented Nov 9, 2017

This looks like a larger PR than it really is since there's a fair bit of template reworking. It's probably fairly digestable per-commit, though I'm happy to split this out into multiple PR's if it's easier.

Motivated by #329, this PR

  • Loads the editor team from GitHub for the reviewer assignment and suggested reviewer on the submission.
  • Generalizes the templates to use a settings.yml file to specify the easily extractable language and configuration
  • Extracts as much customizable content from templates and template structure as possible. These partials now live in app/views/content
  • Adds a simple editors admin management UI at http://staging.joss.theoj.org/editors
    • Can be bootstrapped via the db/seeds
    • Currently, it's independent from the GitHub editor team, but that might be a cool feature.
    • It requires the admin flag on a user account, just ping me if you can't access it
  • Adds a configurable list of paper submission types.

Along with openjournals/whedon-api#11, this should get us into a pretty good position to have multiple journals running. 🎉

In-progress deploys are going to http://staging.joss.theoj.org

Feedback welcome!

@parrish parrish mentioned this pull request Nov 9, 2017
5 tasks
@arfon arfon mentioned this pull request Dec 1, 2017
@vsoch
Copy link
Contributor

vsoch commented Dec 1, 2017

Huge +1 to this work! I started customizing the joss repo and the majority of "manual changes" were changing the content of titles, etc. Has there been discussion about some form of documentation that details development --> deployment? I didn't have familiarity with the development stack but narrowed it down to (after bundling and dealing with dependencies) these steps:


Development

This is an application friendly to run on heroku. So you should first make an account and then follow the instructions to deploy the application. It comes down to:

  1. Login with heroku login
  2. Create the heroku branch with heroku create
heroku create
Creating app... done, ⬢ shielded-mountain-65855
https://shielded-mountain-65855.herokuapp.com/ | https://git.heroku.com/shielded-mountain-65855.git
  1. Migrate the database to create the tables, etc.
heroku run rake db:migrate

Has anyone talked about a Dockerized development server setup? I have something almost working and can do a PR when this gets merged, with some instructions for getting it up and running!

- [ ] **Authors:** Does the `paper.md` file include a list of authors with their affiliations?
- [ ] **A statement of need:** Do the authors clearly state what problems the software is designed to solve and who the target audience is?
- [ ] **References:** Do all archival references that should have a DOI list one (e.g., papers, datasets, software)?
<%- if paper.kind.present? %>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I completely understand this syntax...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, it seems like it's the same as exists?

@arfon arfon mentioned this pull request Dec 1, 2017
@arfon
Copy link
Member

arfon commented Dec 1, 2017

Closing in favour or #361

@arfon arfon closed this Dec 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants