-
-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalize JOSS to better handle multiple instances #353
Conversation
This also adds .ruby-version and .ruby-gemset, pry-byebug, and dotenv.
This is to support multiple review checklists by submission type
Huge +1 to this work! I started customizing the joss repo and the majority of "manual changes" were changing the content of titles, etc. Has there been discussion about some form of documentation that details development --> deployment? I didn't have familiarity with the development stack but narrowed it down to (after bundling and dealing with dependencies) these steps: DevelopmentThis is an application friendly to run on heroku. So you should first make an account and then follow the instructions to deploy the application. It comes down to:
Has anyone talked about a Dockerized development server setup? I have something almost working and can do a PR when this gets merged, with some instructions for getting it up and running! |
- [ ] **Authors:** Does the `paper.md` file include a list of authors with their affiliations? | ||
- [ ] **A statement of need:** Do the authors clearly state what problems the software is designed to solve and who the target audience is? | ||
- [ ] **References:** Do all archival references that should have a DOI list one (e.g., papers, datasets, software)? | ||
<%- if paper.kind.present? %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I completely understand this syntax...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, it seems like it's the same as exists?
Closing in favour or #361 |
This looks like a larger PR than it really is since there's a fair bit of template reworking. It's probably fairly digestable per-commit, though I'm happy to split this out into multiple PR's if it's easier.
Motivated by #329, this PR
Along with openjournals/whedon-api#11, this should get us into a pretty good position to have multiple journals running. 🎉
In-progress deploys are going to http://staging.joss.theoj.org
Feedback welcome!