Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed changes to Node.js TSC Charter require CPC approval #975

Closed
Trott opened this issue Nov 24, 2022 · 12 comments
Closed

Proposed changes to Node.js TSC Charter require CPC approval #975

Trott opened this issue Nov 24, 2022 · 12 comments

Comments

@Trott
Copy link
Contributor

Trott commented Nov 24, 2022

See nodejs/TSC#1311 for proposed changes to the Node.js TSC Charter that require CPC approval.

@ljharb
Copy link
Member

ljharb commented Nov 24, 2022

I approve this change, fwiw.

@eemeli
Copy link
Member

eemeli commented Nov 24, 2022

Added my approval to the nodejs/TSC PR.

@tobie
Copy link
Contributor

tobie commented Nov 24, 2022

LGTM

@anonrig
Copy link
Member

anonrig commented Nov 29, 2022

Approved!

@Trott
Copy link
Contributor Author

Trott commented Nov 30, 2022

Total voting members on CPC: 14

Voting members in favor: 5 (@Trott @tobie @eemeli in this issue and @bnb @mhdawson in nodejs/TSC#1311)

Is a 5-0 vote with 9 implicit abstentions sufficient? Or do we need more participation from voting members to make this official?

(Voting members who have not yet voted: @joesepi @TheLarkInn @sokra @dmethvin @timmywil @erickzhao @dylans @imurchie @Jonahss)

@ljharb

This comment was marked as resolved.

@Trott

This comment was marked as resolved.

@ljharb

This comment was marked as resolved.

ljharb added a commit that referenced this issue Nov 30, 2022
Per #906 (comment)

Noticed here: #975 (comment)

Signed-off-by: Jordan Harband <ljharb@gmail.com>
@mhdawson
Copy link
Member

+1

1 similar comment
@joesepi
Copy link
Member

joesepi commented Nov 30, 2022

+1

@Trott
Copy link
Contributor Author

Trott commented Nov 30, 2022

We now have 8 of the 15 CPC voting members in favor, so I think I can go ahead and land the PR to update the charter. I'll close this, but if there's more to do here (like some sort of official vote certification), please re-open. Thanks!

(@ljharb I hid our comments about your voting status as resolved. Feel free to unhide or whatever if you think I've overstepped.)

@Trott Trott closed this as completed Nov 30, 2022
@dmethvin
Copy link
Contributor

dmethvin commented Dec 1, 2022

+1 even if belated!

anonrig pushed a commit to anonrig/cross-project-council that referenced this issue Jan 24, 2023
Per openjs-foundation#906 (comment)

Noticed here: openjs-foundation#975 (comment)

Signed-off-by: Jordan Harband <ljharb@gmail.com>
tobie pushed a commit that referenced this issue Sep 1, 2023
Per #906 (comment)

Noticed here: #975 (comment)

Signed-off-by: Jordan Harband <ljharb@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants