Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken local anchors #848

Merged
merged 1 commit into from
Apr 8, 2022
Merged

Fix broken local anchors #848

merged 1 commit into from
Apr 8, 2022

Conversation

Relequestual
Copy link
Contributor

Fixes #807

ljharb
ljharb approved these changes Mar 28, 2022
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably also add explicit anchors for the old section names, since cool URLs don’t change.

This was referenced Mar 29, 2022
Open
Closed
mhdawson
mhdawson approved these changes Apr 1, 2022
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bnb bnb merged commit 5626887 into openjs-foundation:main Apr 8, 2022
tobie pushed a commit that referenced this pull request Sep 1, 2023
@Relequestual @tobie
doc: Fix broken local anchors (#848)
5d0f4a3 
Fixes #807
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

@joesepi joesepi joesepi approved these changes

@eemeli eemeli eemeli approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CoC has broken local anchor links
6 participants
@Relequestual @ljharb @joesepi @eemeli @mhdawson @bnb