Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Governance for the Standards Group #22

Merged
merged 4 commits into from
Oct 22, 2019

Conversation

sendilkumarn
Copy link
Member

@sendilkumarn sendilkumarn commented Aug 29, 2019

r? @MylesBorins

Based on the discussion from #21 #19

# OpenJS Standards Group

<!-- yet to add -->
For the current list of Team members, see the project [README.md](./README.md).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should the list maybe be in a separate file, rather than the main readme?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ljharb across the node.js project and within this org we've maintained the list within the readme

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a huge deal, but keeping a changing list in the readme makes it harder to look at git history for the prose in the readme ¯\_(ツ)_/¯

Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some notes in line

Great first pass!

GOVERNANCE.md Outdated Show resolved Hide resolved
GOVERNANCE.md Outdated Show resolved Hide resolved
GOVERNANCE.md Outdated Show resolved Hide resolved
GOVERNANCE.md Outdated Show resolved Hide resolved
GOVERNANCE.md Outdated Show resolved Hide resolved
@sendilkumarn
Copy link
Member Author

Is there something pending to do here?

Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did another quick pass and have some suggestions. We should discuss this in a meeting before landing

GOVERNANCE.md Outdated Show resolved Hide resolved
GOVERNANCE.md Outdated Show resolved Hide resolved
GOVERNANCE.md Outdated Show resolved Hide resolved
sendilkumarn and others added 2 commits September 9, 2019 21:29
Co-Authored-By: Myles Borins <myles.borins@gmail.com>

Pull requests require approval by at least two members and must remain open for at least 72 hours before being landed. If there are any objections the Pull Request cannot land until they are resolved.

A pull request that is opposed will be discussed in the meeting.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be inferred from the above paragraph.... this is a tiny nit though

Copy link
Member

@joesepi joesepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great job @sendilkumarn!

@jorydotcom
Copy link
Member

I really think this is a great first version of this doc, thank you for doing this work @sendilkumarn. We did discuss it at the meeting yesterday, but of course want to make sure everyone has had a chance to see it an +1.

For avoidance of doubt, can we get the @openjs-foundation/standards team & others to add their +1 / review approval?


The Team meets bi-weekly on Zoom.us. A designated moderator
approved by the Team runs the meeting. Each meeting should be
published to YouTube.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the streaming doesn't work for any reasons, should the meeting be postponed?
It happened to one node.js meeting and to be 100% transparency we did it so

@MylesBorins
Copy link
Contributor

MylesBorins commented Sep 17, 2019 via email

@joesepi joesepi merged commit 7e601b5 into openjs-foundation:master Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants