Work on privacy settings #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jzakotnik
reviewed
Mar 22, 2024
There was a problem hiding this comment.
To me it's not clear why cookies are needed for the effectiveness of the documentation. Only the item with the repeated visits is valid. The others (documentation effectiveness, etc) can be solved without cookies, e.g. if you use the open source like https://umami.is/ , you can track the movements on the site in a more anonymous way.
Tested again the number of cookies we are using. Zero.
|
Hi, your point is fair enough. Right now we are using zero cookies from everything I know. So the consent form was mostly pointless and I removed it again. Setting up analytics could be interesting but up to now I was not sure about appropiate ways and always refrained from it. This means that the PR is reduced to the privacy tool as described here. |
|
Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce some privacy settings and consent for the website. Looked kind of nice to have.
https://squidfunk.github.io/mkdocs-material/plugins/privacy/