Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major fix for tests on ligand-based and kinase-informed level. #37

Merged
merged 2 commits into from
Aug 20, 2021

Conversation

t-kimber
Copy link
Contributor

This PR is a copied version of #10 , which is faulty due to merging and reverting issues.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@t-kimber t-kimber removed the request for review from jchodera August 19, 2021 11:45
@t-kimber
Copy link
Contributor Author

@schallerdavid , this is the PR that corrects the faulty we discussed earlier.
It makes the right tests for the featurizers and experiments. It's ready to be merged :)

Copy link
Contributor

@schallerdavid schallerdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@t-kimber t-kimber merged commit 450bc57 into master Aug 20, 2021
@t-kimber t-kimber mentioned this pull request Aug 20, 2021
@t-kimber t-kimber deleted the hot-fix branch August 20, 2021 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants