fix: positioned element logical width/height calculation #1053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
temper357
changed the title
answershuto
approved these changes
Jan 6, 2022
wssgcg1213
reviewed
Jan 6, 2022
| // The width of positioned, non-replaced element is determined as following algorithm. | ||
| // https://www.w3.org/TR/css-position-3/#abs-non-replaced-width | ||
| } else if ((renderStyle.position == CSSPositionType.absolute || | ||
| renderStyle.position == CSSPositionType.fixed) |
wssgcg1213
reviewed
Jan 6, 2022
| // The width of positioned, non-replaced element is determined as following algorithm. | ||
| // https://www.w3.org/TR/css-position-3/#abs-non-replaced-width | ||
| } else if ((renderStyle.position == CSSPositionType.absolute || | ||
| renderStyle.position == CSSPositionType.fixed) |
| } | ||
| // Should access the renderStyle of renderBoxModel parent but not renderStyle parent | ||
| // cause the element of renderStyle parent may not equal to containing block. | ||
| RenderBoxModel parent = current.parent as RenderBoxModel; |
There was a problem hiding this comment.
上面的判断 current.parent is! RenderBoxModel 已经排除了 parent 为 null 的 case
wssgcg1213
approved these changes
Jan 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1051