Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: devtools select dom postion offset #1289

Closed
wants to merge 1 commit into from
Closed

fix: devtools select dom postion offset #1289

wants to merge 1 commit into from

Conversation

devjiangzhou
Copy link

image

@devjiangzhou devjiangzhou changed the title fix devtools select dom postion offset fix: devtools select dom postion offset Apr 2, 2022
wssgcg1213
wssgcg1213 reviewed Apr 12, 2022
View reviewed changes
kraken/lib/src/devtools/modules/dom.dart
@@ -85,7 +85,8 @@ class InspectDOMModule extends UIInspectorModule {

// BoxModel design to BorderBox in kraken.
if (element != null && element.renderBoxModel != null && element.renderBoxModel!.hasSize) {
ui.Offset contentBoxOffset = element.renderBoxModel!.localToGlobal(ui.Offset.zero);
final ancestor = document.controller.rootFlutterElement.renderObject;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里用 viewport 更合适一点

@wssgcg1213 wssgcg1213 mentioned this pull request Apr 12, 2022
Merged
@wssgcg1213
Copy link
Member

See #1315, will solve this problem, thanks for your PR!

@wssgcg1213 wssgcg1213 closed this Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wssgcg1213 wssgcg1213 wssgcg1213 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@devjiangzhou @wssgcg1213