Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: devtools select dom postion offset #1289

Closed
wants to merge 1 commit into from
Closed

fix: devtools select dom postion offset #1289

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion kraken/lib/src/devtools/modules/dom.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,8 @@ class InspectDOMModule extends UIInspectorModule {

// BoxModel design to BorderBox in kraken.
if (element != null && element.renderBoxModel != null && element.renderBoxModel!.hasSize) {
ui.Offset contentBoxOffset = element.renderBoxModel!.localToGlobal(ui.Offset.zero);
final ancestor = document.controller.rootFlutterElement.renderObject;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里用 viewport 更合适一点

ui.Offset contentBoxOffset = element.renderBoxModel!.localToGlobal(ui.Offset.zero, ancestor: ancestor);

int widthWithinBorder = element.renderBoxModel!.size.width.toInt();
int heightWithinBorder = element.renderBoxModel!.size.height.toInt();
Expand Down