fix: devtool console log #1328
Merged
fix: devtool console log #1328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoming0214
commented
Apr 13, 2022
xiaoming0214
commented
wssgcg1213
reviewed
Apr 13, 2022
| @@ -66,6 +66,7 @@ class UIInspector { | |||
| registerModule(InspectPageModule(devtoolsService)); | |||
| registerModule(InspectCSSModule(devtoolsService)); | |||
| registerModule(InspectNetworkModule(devtoolsService)); | |||
| registerModule(InspectorLogModule(devtoolsService)); | |||
There was a problem hiding this comment.
这里命名跟上面统一吧, InspectLogModule
wssgcg1213
reviewed
Apr 13, 2022
| @@ -32,6 +32,7 @@ const int DOCUMENT_ID = -2; | |||
| typedef LoadHandler = void Function(KrakenController controller); | |||
| typedef LoadErrorHandler = void Function(FlutterError error, StackTrace stack); | |||
| typedef JSErrorHandler = void Function(String message); | |||
| typedef JSLogHandler = void Function(int level,String message); | |||
wssgcg1213
reviewed
Apr 13, 2022
| /// Error = 3, | ||
| /// Debug = 4, | ||
| /// Info = 5, | ||
| String getLevelStr(int level){ |
wssgcg1213
reviewed
Apr 13, 2022
| InspectorLogModule(IsolateInspectorServer server): super(server); | ||
| class InspectLogModule extends UIInspectorModule { | ||
| InspectLogModule(ChromeDevToolsService server): super(server){ | ||
| devtoolsService.controller!.onJSLog = (level,message) { |
wssgcg1213
reviewed
Apr 13, 2022
| class InspectorLogModule extends IsolateInspectorModule { | ||
| InspectorLogModule(IsolateInspectorServer server): super(server); | ||
| class InspectLogModule extends UIInspectorModule { | ||
| InspectLogModule(ChromeDevToolsService server): super(server){ |
wssgcg1213
reviewed
Apr 13, 2022
| }; | ||
| } | ||
|
|
||
| void handleMessage(int level, String message){ |
wssgcg1213
reviewed
Apr 13, 2022
| if(controller != null){ | ||
| JSLogHandler? jsLogHandler = controller.onJSLog; | ||
| if (jsLogHandler != null) { | ||
| print('_onJSLog $level $msg'); |
wssgcg1213
reviewed
Apr 13, 2022
| void _onJSLog(int contextId, int level, Pointer<Utf8> charStr) { | ||
| String msg = charStr.toDartString(); | ||
| KrakenController? controller = KrakenController.getControllerOfJSContextId(contextId); | ||
| if(controller != null){ |
|
CI 没过，看起来 crash 了。 |
|
@xiaoming0214 新添加的 dartMethod 在测试环境也得 mock 一下 |
added 2 commits
April 14, 2022 10:32
wssgcg1213
approved these changes
Apr 14, 2022
answershuto
approved these changes
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.