[fix] kraken not support relative protocol #1444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wssgcg1213 see see， 我记得之前有个讨论返回设计需要 URI ？ |
用例不变，前端业务代码无差异。 |
|
info • Private field could be final • lib/src/dom/elements/head.dart:35:21 • prefer_final_fields 测试没过 |
|
看起来和这个pr无关，具体error log在哪里看的 |
|
可以点下面的测试列表，其中 Integration Test / plugin_test (pull_request）里面跑的 lint 挂了 |
andycall
approved these changes
Jul 14, 2022
answershuto
approved these changes
Jul 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[fix] kraken not support relative protocol
由于HistoryModule的_replaceState过程中重新构建了bundle,此bundle未resolve,导致resolvedUri为空。