Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove fit #516

Merged
merged 5 commits into from
Jul 21, 2021
Merged

fix: remove fit #516

merged 5 commits into from
Jul 21, 2021

Conversation

temper357
Copy link
Contributor

@temper357 temper357 commented Jul 19, 2021 •
edited
Loading

  • 修复 feat: support rem and em unit #475 PR 中 fit 未移除导致未发现的测试失败的问题：
    • 去除 test 中 fit。
    • 在 renderer before attach 时不需要 apply style properties。
    • canvas.dart 中取 fontSize 与 rootFontSize 时由于 renderBoxModel 未创建导致测试用例 crash，取将取 fontSize 与 rootFontSize 时机移到 didAttachRenderer。

answershuto
answershuto previously approved these changes Jul 19, 2021
View reviewed changes
answershuto
answershuto previously approved these changes Jul 20, 2021
View reviewed changes
@answershuto answershuto merged commit d0c052e into main Jul 21, 2021
@answershuto answershuto deleted the fix/fit branch July 21, 2021 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andycall andycall andycall approved these changes

@answershuto answershuto answershuto approved these changes

@yuanyan yuanyan Awaiting requested review from yuanyan

@wssgcg1213 wssgcg1213 Awaiting requested review from wssgcg1213

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@temper357 @andycall @answershuto