fix: auto margin in flexbox #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
temper357
requested review from
yuanyan,
wssgcg1213,
andycall and
answershuto
wssgcg1213
reviewed
Sep 9, 2021
wssgcg1213
reviewed
Sep 9, 2021
yuanyan
approved these changes
Sep 10, 2021
wssgcg1213
approved these changes
Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #666
修复当 flex item 配置 margin auto 且 flex 容器上存在 align-items 或者 justify-content 属性时 margin auto 未生效。
fix：规范中有写 flex item 的 margin auto 优先级高于 flex 容器上的对齐类属性（align-items/align-self/justify-content) https://www.w3.org/TR/css-flexbox-1/#auto-margins , 这种 case 下应该跳过对齐类属性的对齐逻辑。