Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: auto margin in flexbox #667

Merged
merged 4 commits into from Sep 13, 2021
Merged

fix: auto margin in flexbox #667

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1db0024
fix: margin auto fail in flexbox
temper357 Sep 9, 2021
cf077fd
test: add tests for margin auto in flexbox
temper357 Sep 9, 2021
a14f549
chore: code opt
temper357 Sep 9, 2021
77a80e2
chore: code opt
temper357 Sep 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Binary file added integration_tests/snapshots/css/css-flexbox/auto-margins.ts.13f4e4eb1.png
View file
Open in desktop
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added integration_tests/snapshots/css/css-flexbox/auto-margins.ts.c5780e3b1.png
View file
Open in desktop
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added integration_tests/snapshots/css/css-flexbox/auto-margins.ts.c8f986311.png
View file
Open in desktop
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added integration_tests/snapshots/css/css-flexbox/auto-margins.ts.e70382641.png
View file
Open in desktop
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
124 changes: 124 additions & 0 deletions integration_tests/specs/css/css-flexbox/auto-margins.ts
View file
Open in desktop
Expand Up @@ -72,4 +72,128 @@ describe('auto-margins', () => {
};
await snapshot();
});

it('align-items should not work when auto margin exists in flex column direction', async () => {
let div;
div = createElement(
'div',
{
style: {
display: 'flex',
flexDirection: 'column',
alignItems: 'flex-end',
width: '300px',
height: '300px',
backgroundColor: 'green'
},
},
[
createElement('div', {
style: {
width: '100px',
height: '100px',
margin: '0 auto',
backgroundColor: 'yellow',
}
}),
]
);

BODY.appendChild(div);

await snapshot();
});

it('align-items should not work when auto margin exists in flex row direction', async () => {
let div;
div = createElement(
'div',
{
style: {
display: 'flex',
flexDirection: 'row',
alignItems: 'flex-end',
width: '300px',
height: '300px',
backgroundColor: 'green'
},
},
[
createElement('div', {
style: {
width: '100px',
height: '100px',
margin: 'auto 0',
backgroundColor: 'yellow',
}
}),
]
);

BODY.appendChild(div);

await snapshot();
});

it('justify-content should not work when auto margin exists in flex column direction', async () => {
let div;
div = createElement(
'div',
{
style: {
display: 'flex',
flexDirection: 'column',
justifyContent: 'flex-end',
width: '300px',
height: '300px',
backgroundColor: 'green'
},
},
[
createElement('div', {
style: {
width: '100px',
height: '100px',
margin: 'auto 0',
backgroundColor: 'yellow',
}
}),
]
);

BODY.appendChild(div);

await snapshot();
});

it('justify-content should not work when auto margin exists in flex row direction', async () => {
let div;
div = createElement(
'div',
{
style: {
display: 'flex',
flexDirection: 'row',
justifyContent: 'flex-end',
width: '300px',
height: '300px',
backgroundColor: 'green'
},
},
[
createElement('div', {
style: {
width: '100px',
height: '100px',
margin: '0 auto',
backgroundColor: 'yellow',
}
}),
]
);

BODY.appendChild(div);

await snapshot();
});
});