-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rollout v0.1.0 #8
Conversation
charts/rollout/Chart.yaml
Outdated
@@ -0,0 +1,23 @@ | |||
apiVersion: v2 | |||
name: rollout |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kruise-rollout
charts/rollout/Chart.yaml
Outdated
@@ -0,0 +1,23 @@ | |||
apiVersion: v2 | |||
name: rollout | |||
description: A Helm chart for Kubernetes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A Helm chart for kruise-rollout components
charts/rollout/Chart.yaml
Outdated
# This is the version number of the application being deployed. This version number should be | ||
# incremented each time you make changes to the application. Versions are not expected to | ||
# follow Semantic Versioning. They should reflect the version the application is using. | ||
appVersion: 1.16.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
appVersion
is the version of the app in this chart, which is kruise-rollout. So it should also be 0.1.0
.
metadata: | ||
name: kruise-rollout-webhook-service | ||
namespace: {{ .Values.installation.namespace }} | ||
spec: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can set clusterIP: None
to make it a headless service.
charts/rollout/values.yaml
Outdated
# values for rollout installation | ||
installation: | ||
namespace: kruise-rollout | ||
roleListGroups: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be removed.
charts/rollout/values.yaml
Outdated
replicaCount: 2 | ||
|
||
image: | ||
repository: openkruise/rollout-manager |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
openkruise/kruise-rollout-manager
kruise-rollout v0.1.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FillZpp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: liheng.zms liheng.zms@alibaba-inc.com
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Changes are automatically published when merged to
master
. They are not published on branches.