rollout v0.1.0 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FillZpp
reviewed
Feb 23, 2022
charts/rollout/Chart.yaml
Outdated
| @@ -0,0 +1,23 @@ | |||
| apiVersion: v2 | |||
| name: rollout | |||
charts/rollout/Chart.yaml
Outdated
| @@ -0,0 +1,23 @@ | |||
| apiVersion: v2 | |||
| name: rollout | |||
| description: A Helm chart for Kubernetes | |||
There was a problem hiding this comment.
A Helm chart for kruise-rollout components
charts/rollout/Chart.yaml
Outdated
| # This is the version number of the application being deployed. This version number should be | ||
| # incremented each time you make changes to the application. Versions are not expected to | ||
| # follow Semantic Versioning. They should reflect the version the application is using. | ||
| appVersion: 1.16.0 |
There was a problem hiding this comment.
appVersion is the version of the app in this chart, which is kruise-rollout. So it should also be 0.1.0.
| metadata: | ||
| name: kruise-rollout-webhook-service | ||
| namespace: {{ .Values.installation.namespace }} | ||
| spec: |
There was a problem hiding this comment.
We can set clusterIP: None to make it a headless service.
charts/rollout/values.yaml
Outdated
| # values for rollout installation | ||
| installation: | ||
| namespace: kruise-rollout | ||
| roleListGroups: |
charts/rollout/values.yaml
Outdated
| replicaCount: 2 | ||
|
|
||
| image: | ||
| repository: openkruise/rollout-manager |
There was a problem hiding this comment.
openkruise/kruise-rollout-manager
kruise-rollout v0.1.0
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FillZpp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: liheng.zms liheng.zms@alibaba-inc.com
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Changes are automatically published when merged to
master. They are not published on branches.