fix: update alpine base image #1166

fengshunli · 2023-01-17T16:30:07Z

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

sonatype-lift · 2023-01-18T08:29:54Z

Dockerfile

-  && apt-get clean && rm -rf /var/log/*log /var/lib/apt/lists/* /var/log/apt/* /var/lib/dpkg/*-old /var/cache/debconf/*-old
+FROM alpine:3.17
+
+RUN apk --no-cache add ca-certificates \


DL3018: Pin versions in apk add. Instead of apk add <package> use apk add <package>=<version>

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-01-18T08:43:47Z

Dockerfile

-  && apt-get clean && rm -rf /var/log/*log /var/lib/apt/lists/* /var/log/apt/* /var/lib/dpkg/*-old /var/cache/debconf/*-old
+FROM alpine:3.17
+
+RUN apk add ca-certificates \


DL3018: Pin versions in apk add. Instead of apk add <package> use apk add <package>=<version>

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-01-18T08:43:50Z

Dockerfile

-  && apt-get clean && rm -rf /var/log/*log /var/lib/apt/lists/* /var/log/apt/* /var/lib/dpkg/*-old /var/cache/debconf/*-old
+FROM alpine:3.17
+
+RUN apk add ca-certificates \


DL3019: Use the --no-cache switch to avoid the need to use --update and remove /var/cache/apk/* when done installing packages

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-01-18T09:43:48Z

Dockerfile

-  && apt-get clean && rm -rf /var/log/*log /var/lib/apt/lists/* /var/log/apt/* /var/lib/dpkg/*-old /var/cache/debconf/*-old
+FROM alpine:3.17
+
+RUN apk --no-cache add  ca-certificates \


DL3018: Pin versions in apk add. Instead of apk add <package> use apk add <package>=<version>

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

StevenLeiZhang · 2023-01-18T14:24:20Z

Dockerfile

-RUN ln -s /usr/bin/* /usr/sbin/ && apt-get update -y \
-  && apt-get install --no-install-recommends -y ca-certificates \
-  && apt-get clean && rm -rf /var/log/*log /var/lib/apt/lists/* /var/log/apt/* /var/lib/dpkg/*-old /var/cache/debconf/*-old
+FROM alpine:3.17


I suggest to use

ARG BASE_IMAGE

and set its default value is alpine:3.17, then user could customize the base image.

@StevenLeiZhang updated

sonatype-lift · 2023-01-18T14:46:41Z

Dockerfile

-  && apt-get clean && rm -rf /var/log/*log /var/lib/apt/lists/* /var/log/apt/* /var/lib/dpkg/*-old /var/cache/debconf/*-old
+ARG BASE_IMAGE=alpine:3.17
+
+FROM $BASE_IMAGE


DL3006: Always tag the version of an image explicitly

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

zmberg · 2023-01-31T03:35:50Z

@fengshunli You should solve the failed checks, and confirm all checks are successful.

sonatype-lift · 2023-01-31T04:00:09Z

Dockerfile

-  && apt-get clean && rm -rf /var/log/*log /var/lib/apt/lists/* /var/log/apt/* /var/lib/dpkg/*-old /var/cache/debconf/*-old
+ARG BASE_IMAGE=alpine:3.17
+
+FROM ${BASE_IMAGE}


DL3006: Always tag the version of an image explicitly

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-01-31T04:51:07Z

Dockerfile

-  && apt-get clean && rm -rf /var/log/*log /var/lib/apt/lists/* /var/log/apt/* /var/lib/dpkg/*-old /var/cache/debconf/*-old
+ARG BASE_IMAGE
+
+FROM ${BASE_IMAGE:alpine:3.17}


DL1000: unexpected ':'
expecting '@', '', a new line followed by the next instruction, or the image tag

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-01-31T05:29:13Z

Dockerfile

-RUN ln -s /usr/bin/* /usr/sbin/ && apt-get update -y \
-  && apt-get install --no-install-recommends -y ca-certificates \
-  && apt-get clean && rm -rf /var/log/*log /var/lib/apt/lists/* /var/log/apt/* /var/lib/dpkg/*-old /var/cache/debconf/*-old
+FROM ${BASE_IMAGE:-alpine:3.17}


DL1000: unexpected ':'
expecting '@', '', a new line followed by the next instruction, or the image tag

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

zmberg · 2023-02-02T08:00:33Z

Dockerfile

-RUN ln -s /usr/bin/* /usr/sbin/ && apt-get update -y \
-  && apt-get install --no-install-recommends -y ca-certificates \
-  && apt-get clean && rm -rf /var/log/*log /var/lib/apt/lists/* /var/log/apt/* /var/lib/dpkg/*-old /var/cache/debconf/*-old
+FROM ${BASE_IMAGE}:${BASE_IMAGE_VERSION}


Format failed, I suggest you rewrite again.

zmberg · 2023-02-02T08:00:52Z

Dockerfile

-  && apt-get clean && rm -rf /var/log/*log /var/lib/apt/lists/* /var/log/apt/* /var/lib/dpkg/*-old /var/cache/debconf/*-old
+FROM ${BASE_IMAGE}:${BASE_IMAGE_VERSION}
+
+RUN apk --no-cache add  ca-certificates=20230106-r0 \


RUN apk add --no-cache ca-certificates bash expat ?

Signed-off-by: fsl <1171313930@qq.com>

zmberg · 2023-02-03T05:13:41Z

/lgtm

zmberg · 2023-02-07T02:02:24Z

/approve

kruise-bot · 2023-02-07T02:02:33Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zmberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [zmberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kruise-bot requested review from FillZpp and furykerry January 17, 2023 16:30

kruise-bot added the size/XS size/XS: 0-9 label Jan 17, 2023

fengshunli mentioned this pull request Jan 17, 2023

[REQUEST Membership]: New membership for fsl openkruise/community#10

Closed

6 tasks

fengshunli force-pushed the alpine branch 2 times, most recently from f86bf32 to 5f8766d Compare January 18, 2023 08:20

kruise-bot added size/M size/M: 30-99 and removed size/XS size/XS: 0-9 labels Jan 18, 2023

sonatype-lift bot reviewed Jan 18, 2023

View reviewed changes

fengshunli force-pushed the alpine branch from 5f8766d to b5d908c Compare January 18, 2023 08:34

sonatype-lift bot reviewed Jan 18, 2023

View reviewed changes

fengshunli force-pushed the alpine branch from b5d908c to 0976c94 Compare January 18, 2023 09:34

sonatype-lift bot reviewed Jan 18, 2023

View reviewed changes

StevenLeiZhang reviewed Jan 18, 2023

View reviewed changes

fengshunli force-pushed the alpine branch from 0976c94 to 99040e6 Compare January 18, 2023 14:37

sonatype-lift bot reviewed Jan 18, 2023

View reviewed changes

fengshunli force-pushed the alpine branch from 99040e6 to fbed1c8 Compare January 31, 2023 03:50

sonatype-lift bot reviewed Jan 31, 2023

View reviewed changes

fengshunli force-pushed the alpine branch from fbed1c8 to 885b186 Compare January 31, 2023 04:41

sonatype-lift bot reviewed Jan 31, 2023

View reviewed changes

fengshunli force-pushed the alpine branch from 885b186 to 9d9abee Compare January 31, 2023 05:19

sonatype-lift bot reviewed Jan 31, 2023

View reviewed changes

fengshunli force-pushed the alpine branch 2 times, most recently from 0fa1078 to 9ba2ca8 Compare January 31, 2023 08:41

zmberg reviewed Feb 2, 2023

View reviewed changes

fengshunli force-pushed the alpine branch from 9ba2ca8 to f6e3949 Compare February 2, 2023 11:56

fix: update alpine base image

70cc4e3

Signed-off-by: fsl <1171313930@qq.com>

fengshunli force-pushed the alpine branch from f6e3949 to 70cc4e3 Compare February 2, 2023 12:07

kruise-bot assigned zmberg Feb 3, 2023

kruise-bot added the lgtm label Feb 3, 2023

kruise-bot added the approved label Feb 7, 2023

kruise-bot merged commit 68e9312 into openkruise:master Feb 7, 2023

zmberg added this to In progress in Roadmap via automation Feb 14, 2023

zmberg added this to the v1.4 milestone Feb 14, 2023

zmberg moved this from In progress to Done in Roadmap Feb 14, 2023

zmberg added the kind/enhancement New feature or request label Feb 14, 2023

ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024

fix: update alpine base image (openkruise#1166)

20e5799

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: update alpine base image #1166

fix: update alpine base image #1166

fengshunli commented Jan 17, 2023

sonatype-lift bot Jan 18, 2023

sonatype-lift bot Jan 18, 2023

sonatype-lift bot Jan 18, 2023

sonatype-lift bot Jan 18, 2023

StevenLeiZhang Jan 18, 2023

fengshunli Jan 18, 2023

sonatype-lift bot Jan 18, 2023

zmberg commented Jan 31, 2023

sonatype-lift bot Jan 31, 2023

sonatype-lift bot Jan 31, 2023

sonatype-lift bot Jan 31, 2023

zmberg Feb 2, 2023

zmberg Feb 2, 2023

zmberg commented Feb 3, 2023

zmberg commented Feb 7, 2023

kruise-bot commented Feb 7, 2023

Command	Usage
`@sonatype-lift ignore`	Leave out the above finding from this PR
`@sonatype-lift ignoreall`	Leave out all the existing findings from this PR
`@sonatype-lift exclude <file\|issue\|path\|tool>`	Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file

fix: update alpine base image #1166

fix: update alpine base image #1166

Conversation

fengshunli commented Jan 17, 2023

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

sonatype-lift bot Jan 18, 2023

Choose a reason for hiding this comment

sonatype-lift bot Jan 18, 2023

Choose a reason for hiding this comment

sonatype-lift bot Jan 18, 2023

Choose a reason for hiding this comment

sonatype-lift bot Jan 18, 2023

Choose a reason for hiding this comment

StevenLeiZhang Jan 18, 2023

Choose a reason for hiding this comment

fengshunli Jan 18, 2023

Choose a reason for hiding this comment

sonatype-lift bot Jan 18, 2023

Choose a reason for hiding this comment

zmberg commented Jan 31, 2023

sonatype-lift bot Jan 31, 2023

Choose a reason for hiding this comment

sonatype-lift bot Jan 31, 2023

Choose a reason for hiding this comment

sonatype-lift bot Jan 31, 2023

Choose a reason for hiding this comment

zmberg Feb 2, 2023

Choose a reason for hiding this comment

zmberg Feb 2, 2023

Choose a reason for hiding this comment

zmberg commented Feb 3, 2023

zmberg commented Feb 7, 2023

kruise-bot commented Feb 7, 2023