Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open partial feature-gates by default #1214

Merged
merged 1 commit into from Mar 16, 2023

Conversation

zmberg
Copy link
Member

@zmberg zmberg commented Mar 9, 2023

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@kruise-bot kruise-bot added the size/S size/S 10-29 label Mar 9, 2023
@zmberg zmberg added this to the v1.5 milestone Mar 13, 2023
@zmberg zmberg requested review from veophi and furykerry and removed request for FillZpp and Fei-Guo March 13, 2023 03:08
@zmberg zmberg modified the milestones: v1.5, v1.4 Mar 13, 2023
Copy link
Member

@furykerry furykerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>
@zmberg zmberg force-pushed the open_partial_feature_gates branch from 85c02d1 to dc63b37 Compare March 16, 2023 01:56
@kruise-bot kruise-bot removed the lgtm label Mar 16, 2023
@furykerry
Copy link
Member

/lgtm

@furykerry
Copy link
Member

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furykerry

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 83eff34 into openkruise:master Mar 16, 2023
21 checks passed
diannaowa pushed a commit to diannaowa/kruise that referenced this pull request Jun 2, 2023
Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>
diannaowa pushed a commit to diannaowa/kruise that referenced this pull request Jun 2, 2023
Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants