add prometheus for pub and deletion protection #1398
Conversation
zmberg
force-pushed
the
protection_metrics_v2
branch
from
dcf01cb
to
9e8d182
Compare
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more. @@ Coverage Diff @@
## master #1398 +/- ##
==========================================
- Coverage 48.25% 48.24% -0.01%
==========================================
Files 152 153 +1
Lines 21469 21492 +23
==========================================
+ Hits 10359 10369 +10
- Misses 9973 9984 +11
- Partials 1137 1139 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| @@ -133,7 +129,7 @@ func (c *realControl) Update(cs *appsv1alpha1.CloneSet, | |||
| for _, idx := range waitUpdateIndexes { | |||
| pod := pods[idx] | |||
| // Determine the pub before updating the pod | |||
| if utilfeature.DefaultFeatureGate.Enabled(features.PodUnavailableBudgetUpdateGate) { | |||
| /*if utilfeature.DefaultFeatureGate.Enabled(features.PodUnavailableBudgetUpdateGate) { | |||
There was a problem hiding this comment.
plz comment why delete this code
Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>
zmberg
force-pushed
the
protection_metrics_v2
branch
from
9e8d182
to
d2a98b7
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: furykerry The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews