Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fixed some error messages #1429

Merged
merged 1 commit into from Oct 9, 2023
Merged

Conversation

ls-2018
Copy link
Member

@ls-2018 ls-2018 commented Sep 27, 2023

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

Signed-off-by: 刘硕 <liushuo@zetyun.com>
@codecov-commenter
Copy link

Codecov Report

Merging #1429 (86849f3) into master (81b5d52) will decrease coverage by 0.04%.
The diff coverage is 18.75%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master    #1429      +/-   ##
==========================================
- Coverage   48.27%   48.24%   -0.04%     
==========================================
  Files         153      153              
  Lines       21493    21501       +8     
==========================================
- Hits        10376    10373       -3     
- Misses       9979     9988       +9     
- Partials     1138     1140       +2     
Flag Coverage Δ
unittests 48.24% <18.75%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...bemarker/validating/probe_create_update_handler.go 52.20% <18.75%> (-2.77%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zmberg
Copy link
Member

zmberg commented Oct 9, 2023

/lgtm

@kruise-bot kruise-bot added the lgtm label Oct 9, 2023
@zmberg
Copy link
Member

zmberg commented Oct 9, 2023

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zmberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 459efe6 into openkruise:master Oct 9, 2023
23 checks passed
@ls-2018 ls-2018 deleted the ppp branch October 9, 2023 03:39
@zmberg zmberg added this to the 1.6 milestone Mar 7, 2024
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
Co-authored-by: 刘硕 <liushuo@zetyun.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants