Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the number of updateNodePodProbes calls #1430

Merged
merged 1 commit into from Oct 17, 2023

Conversation

ls-2018
Copy link
Member

@ls-2018 ls-2018 commented Sep 28, 2023

Ⅰ. Describe what this PR does

Currently, the update npp is called once per pod, and now the npp is updated once after the Pods are grouped by nodename. It reduces the pressure on apiserver

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

Signed-off-by: 刘硕 <liushuo@zetyun.com>
@kruise-bot kruise-bot added the size/M size/M: 30-99 label Sep 28, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #1430 (ab117bd) into master (81b5d52) will decrease coverage by 0.04%.
The diff coverage is 92.85%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master    #1430      +/-   ##
==========================================
- Coverage   48.27%   48.24%   -0.04%     
==========================================
  Files         153      153              
  Lines       21493    21498       +5     
==========================================
- Hits        10376    10371       -5     
- Misses       9979     9987       +8     
- Partials     1138     1140       +2     
Flag Coverage Δ
unittests 48.24% <92.85%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ller/podprobemarker/pod_probe_marker_controller.go 53.80% <92.85%> (+1.12%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@furykerry furykerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@zmberg
Copy link
Member

zmberg commented Oct 17, 2023

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zmberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit b9484d6 into openkruise:master Oct 17, 2023
23 checks passed
@ls-2018 ls-2018 deleted the yoou branch October 23, 2023 01:46
@zmberg zmberg added this to the 1.6 milestone Mar 7, 2024
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants