fix: validate update AdvancedDaemonSet

[hantmac]

Ⅰ. Describe what this PR does

Fix #1498

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Run test TestValidateDaemonSetUpdate or update Advanced DaemonSet Spec.Selector will get error

Ⅳ. Special notes for reviews

[codecov]

Codecov Report

Attention: Patch coverage is 34.78261% with 30 lines in your changes are missing coverage. Please review.

Project coverage is 47.81%. Comparing base (5421ee7) to head (603a441).
Report is 6 commits behind head on master.

Files	Patch %	Lines
...nset/validating/daemonset_create_update_handler.go	33.33%	30 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1505      +/-   ##
==========================================
- Coverage   48.55%   47.81%   -0.75%     
==========================================
  Files         157      161       +4     
  Lines       22480    23395     +915     
==========================================
+ Hits        10916    11187     +271     
- Misses      10360    10995     +635     
- Partials     1204     1213       +9     

Flag	Coverage Δ
unittests	47.81% <34.78%> (-0.75%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[zmberg]

@hantmac your UT coverage is estimated to be a bit fuller.

[hantmac]

@hantmac your UT coverage is estimated to be a bit fuller.

These test cover the added code. I can't add more UT 😢

[furykerry]

These test cover the added code. I can't add more UT

can you modify the UT to invoke DaemonSetCreateUpdateHandler.Handle function, UT should cover the published function

[hantmac]

These test cover the added code. I can't add more UT

can you modify the UT to invoke DaemonSetCreateUpdateHandler.Handle function, UT should cover the published function

It sounds somewhat unreasonable. It seems like for the sake of UT, just UT 🤔

[furykerry]

/lgtm

[zmberg]

/lgtm

[zmberg]

/approve

[kruise-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zmberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [zmberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment