PodWebhook=false will not disable ResourcesDeletionProtection #1526
Conversation
Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1526 +/- ##
==========================================
+ Coverage 47.90% 47.92% +0.01%
==========================================
Files 161 162 +1
Lines 23425 23483 +58
==========================================
+ Hits 11222 11254 +32
- Misses 10989 11010 +21
- Partials 1214 1219 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CHANGELOG.md
Outdated
| @@ -11,6 +11,7 @@ However it's still possible to use OpenKruise with Kubernetes versions 1.16 and | |||
| - OpenKruise leader election default to use leases mode. ([#1407](https://github.com/openkruise/kruise/pull/1407), [dsxing](https://github.com/dsxing)) | |||
| For users with OpenKruise version 1.3.0 or lower, please first upgrade your OpenKruise to version 1.4 or 1.5 before upgrading to 1.6.0, so as to avoid unexpected multiple leader problem during the installation. | |||
| - Bump Kubernetes dependency to 1.26.10. ([#1511](https://github.com/openkruise/kruise/pull/1511), [KaiShi](https://github.com/BH4AWS)) | |||
| - Features of SidecarSet, WorkloadSpread, PodUnavailableBudget, ResourcesDeletionProtection, ContainerLaunchPriority, PersistentPodState no longer work for resources under namespace kube-system. | |||
There was a problem hiding this comment.
plz provide contributor(hantmac) and PR link, and explain why enforce this limitation. e.g.
To avoid potential circular dependency problem, features rely on webhook will no longer work for resources under kube-system, e.g. SidecarSet, WorkloadSpread, PodUnavailableBudget, ResourcesDeletionProtection, ContainerLaunchPriority and PersistentPodState.
…ystem Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>
zmberg
force-pushed
the
fix-feature-gates
branch
from
28254c9
to
675f563
Compare
|
/lgtm |
zmberg
force-pushed
the
fix-feature-gates
branch
from
40b6c16
to
4f54aff
Compare
| @@ -242,7 +242,7 @@ func (r *ReconcileImagePullJob) Reconcile(_ context.Context, request reconcile.R | |||
| return reconcile.Result{}, nil | |||
| } | |||
| klog.V(4).Infof("Not satisfied resourceVersion for %v, wait for NodeImage %v updating", request.String(), nodeImage.Name) | |||
| return reconcile.Result{RequeueAfter: expectations.ExpectationTimeout - unsatisfiedDuration}, nil | |||
| return reconcile.Result{RequeueAfter: time.Second * 5}, nil | |||
There was a problem hiding this comment.
plz leave in the code about what problem to be solved
Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>
zmberg
force-pushed
the
fix-feature-gates
branch
from
4f54aff
to
b2998f1
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: furykerry The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* PodWebhook=false will not disable ResourcesDeletionProtection Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com> * changelog feature no longer work for resources under namespace kube-system Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com> * change imagepulljob reconcile RequeueAfter=5s Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com> --------- Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>
…uise#1526) * PodWebhook=false will not disable ResourcesDeletionProtection * changelog feature no longer work for resources under namespace kube-system * change imagepulljob reconcile RequeueAfter=5s ---------
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews