Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update go mod, remove dep replace #1527

Merged
merged 1 commit into from Mar 20, 2024

Conversation

BH4AWS
Copy link
Collaborator

@BH4AWS BH4AWS commented Mar 20, 2024

Ⅰ. Describe what this PR does

we update the project dep go.mod, and remove the replace process.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@kruise-bot kruise-bot added the size/M size/M: 30-99 label Mar 20, 2024
@kruise-bot kruise-bot added size/XXL and removed size/M size/M: 30-99 labels Mar 20, 2024
Signed-off-by: jicheng.sk <jicheng.sk@alibaba-inc.com>
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.92%. Comparing base (c33088b) to head (e8f01fc).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1527      +/-   ##
==========================================
+ Coverage   47.89%   47.92%   +0.02%     
==========================================
  Files         161      162       +1     
  Lines       23425    23483      +58     
==========================================
+ Hits        11220    11254      +34     
- Misses      10990    11010      +20     
- Partials     1215     1219       +4     
Flag Coverage Δ
unittests 47.92% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@furykerry furykerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@furykerry
Copy link
Member

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furykerry

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit d3cae3d into openkruise:master Mar 20, 2024
34 checks passed
zmberg pushed a commit that referenced this pull request Mar 21, 2024
Signed-off-by: jicheng.sk <jicheng.sk@alibaba-inc.com>
Co-authored-by: jicheng.sk <jicheng.sk@alibaba-inc.com>
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
Co-authored-by: jicheng.sk <jicheng.sk@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants