Support Path and QueryParams in http route matches #204

lujiajing1126 · 2024-03-12T10:40:59Z

Ⅰ. Describe what this PR does

Add support for Path and QueryParams

Ⅱ. Does this pull request fix one issue?

Fixes #205

Ⅲ. Special notes for reviews

Supported list for Path:

Istio

Supported list for QueryParams:

Gateway API
Istio
MSE Ingress

kruise-bot · 2024-03-12T10:41:16Z

Welcome @lujiajing1126! It looks like this is your first PR to openkruise/rollouts 🎉

codecov · 2024-03-12T15:19:33Z

Codecov Report

Attention: Patch coverage is 78.26087% with 5 lines in your changes missing coverage. Please review.

Project coverage is 43.45%. Comparing base (07c1731) to head (48bd9ea).
Report is 1 commits behind head on master.

❗ Current head 48bd9ea differs from pull request most recent head 5720914

Please upload reports for the commit 5720914 to get more accurate results.

Files	Patch %	Lines
pkg/trafficrouting/network/gateway/gateway.go	50.00%	1 Missing and 2 partials ⚠️
pkg/trafficrouting/manager.go	71.42%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #204      +/-   ##
==========================================
- Coverage   43.63%   43.45%   -0.19%     
==========================================
  Files          52       52              
  Lines        5681     5682       +1     
==========================================
- Hits         2479     2469      -10     
- Misses       2778     2787       +9     
- Partials      424      426       +2

Flag	Coverage Δ
unittests	`43.45% <78.26%> (-0.19%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Megrez Lu <lujiajing1126@gmail.com>

…idering case-insensitivity. (openkruise#200) * Fixed a bug caused by NOT considering case-insensitivity. Signed-off-by: yunbo <yunbo10124scut@gmail.com> * add DisableGenerateCanaryService for CanaryStrategy amend1: update crd yaml amend2: add DisableGenerateCanaryService for v1alpha1 Signed-off-by: yunbo <yunbo10124scut@gmail.com> --------- Signed-off-by: yunbo <yunbo10124scut@gmail.com> Co-authored-by: yunbo <yunbo10124scut@gmail.com> Signed-off-by: Megrez Lu <lujiajing1126@gmail.com>

Signed-off-by: Megrez Lu <lujiajing1126@gmail.com>

api/v1alpha1/rollout_types.go

api/v1beta1/rollout_types.go

pkg/trafficrouting/manager.go

lujiajing1126 · 2024-04-02T03:43:17Z

I have some misunderstanding on the logical operator used for RouteMatcher. I have checked it again last week. Now I believe Istio and GatewayAPI have similar semantics.

I will refactor the proposal and the implementation soon.

Signed-off-by: Megrez Lu <lujiajing1126@gmail.com>

lujiajing1126 · 2024-05-15T08:56:22Z

I've refactored semantics and implemented for MSE and istio scenarios. PTAL @zmberg

Also the proposal has been updated. E2E tests are added as requested.

zmberg · 2024-06-12T05:20:57Z

/lgtm

zmberg · 2024-06-12T05:21:07Z

/approve

kruise-bot · 2024-06-12T05:21:13Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zmberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [zmberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kruise-bot requested review from FillZpp and furykerry March 12, 2024 10:41

kruise-bot added the size/XL label Mar 12, 2024

lujiajing1126 and others added 9 commits March 15, 2024 16:59

support queryparams for gateway api

7eaa44c

Signed-off-by: Megrez Lu <lujiajing1126@gmail.com>

support mse

f6b2738

Signed-off-by: Megrez Lu <lujiajing1126@gmail.com>

support path and queryParams

e120f2b

Signed-off-by: Megrez Lu <lujiajing1126@gmail.com>

fix lint

ae27665

Signed-off-by: Megrez Lu <lujiajing1126@gmail.com>

fix testcase

6b7a8b2

Signed-off-by: Megrez Lu <lujiajing1126@gmail.com>

fix manifests

0741d22

Signed-off-by: Megrez Lu <lujiajing1126@gmail.com>

do not provide default value for path

d8f30b0

Signed-off-by: Megrez Lu <lujiajing1126@gmail.com>

revert test images

48bd9ea

Signed-off-by: Megrez Lu <lujiajing1126@gmail.com>

lujiajing1126 force-pushed the support-more-http-route-matches branch from 778ffc5 to 48bd9ea Compare March 15, 2024 08:59

zmberg reviewed Apr 2, 2024

View reviewed changes

api/v1alpha1/rollout_types.go Outdated Show resolved Hide resolved

api/v1beta1/rollout_types.go Outdated Show resolved Hide resolved

pkg/trafficrouting/manager.go Outdated Show resolved Hide resolved

lujiajing1126 added 8 commits May 14, 2024 08:52

Merge branch 'master' into support-more-http-route-matches

d6db4dd

polish comments

8e02b8b

Signed-off-by: Megrez Lu <lujiajing1126@gmail.com>

add gateway api tests

bd7d65f

Signed-off-by: Megrez Lu <lujiajing1126@gmail.com>

fix MSE cases

5d812d9

Signed-off-by: Megrez Lu <lujiajing1126@gmail.com>

update golang lint ci

53e2f69

Signed-off-by: Megrez Lu <lujiajing1126@gmail.com>

regenerate manifests

9eaa791

Signed-off-by: Megrez Lu <lujiajing1126@gmail.com>

remove generic usage

2c495cb

Signed-off-by: Megrez Lu <lujiajing1126@gmail.com>

update istio lua script

c2d4d5b

Signed-off-by: Megrez Lu <lujiajing1126@gmail.com>

kruise-bot added size/XXL and removed size/XL labels May 14, 2024

lujiajing1126 added 3 commits May 14, 2024 18:02

update v1alpha1 in e2e to v1beta1

9985a2f

Signed-off-by: Megrez Lu <lujiajing1126@gmail.com>

fix cases

d0fad8d

Signed-off-by: Megrez Lu <lujiajing1126@gmail.com>

refactor istio case to include queryParams and path

bed81a6

Signed-off-by: Megrez Lu <lujiajing1126@gmail.com>

lujiajing1126 added 3 commits May 15, 2024 15:14

fix cloneset issue

c19ecc8

Signed-off-by: Megrez Lu <lujiajing1126@gmail.com>

fix typo

1fc4d41

Signed-off-by: Megrez Lu <lujiajing1126@gmail.com>

revert images

5720914

Signed-off-by: Megrez Lu <lujiajing1126@gmail.com>

kruise-bot assigned zmberg Jun 12, 2024

kruise-bot added the lgtm label Jun 12, 2024

kruise-bot added the approved label Jun 12, 2024

kruise-bot merged commit 62794dc into openkruise:master Jun 12, 2024
19 checks passed

lujiajing1126 deleted the support-more-http-route-matches branch June 12, 2024 05:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support Path and QueryParams in http route matches #204

Support Path and QueryParams in http route matches #204

lujiajing1126 commented Mar 12, 2024 •

edited

kruise-bot commented Mar 12, 2024

codecov bot commented Mar 12, 2024 •

edited

lujiajing1126 commented Apr 2, 2024

lujiajing1126 commented May 15, 2024 •

edited

zmberg commented Jun 12, 2024

zmberg commented Jun 12, 2024

kruise-bot commented Jun 12, 2024

Support Path and QueryParams in http route matches #204

Support Path and QueryParams in http route matches #204

Conversation

lujiajing1126 commented Mar 12, 2024 • edited

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Special notes for reviews

kruise-bot commented Mar 12, 2024

codecov bot commented Mar 12, 2024 • edited

Codecov Report

lujiajing1126 commented Apr 2, 2024

lujiajing1126 commented May 15, 2024 • edited

zmberg commented Jun 12, 2024

zmberg commented Jun 12, 2024

kruise-bot commented Jun 12, 2024

lujiajing1126 commented Mar 12, 2024 •

edited

codecov bot commented Mar 12, 2024 •

edited

lujiajing1126 commented May 15, 2024 •

edited