-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Not generating Canary Service && Fixed a bug caused by NOT considering case-insensitivity. #200
Conversation
Welcome @myname4423! It looks like this is your first PR to openkruise/rollouts 🎉 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #200 +/- ##
=======================================
Coverage 43.41% 43.42%
=======================================
Files 52 52
Lines 5675 5677 +2
=======================================
+ Hits 2464 2465 +1
- Misses 2786 2787 +1
Partials 425 425
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Signed-off-by: yunbo <yunbo10124scut@gmail.com>
New changes are detected. LGTM label has been removed. |
amend1: update crd yaml amend2: add DisableGenerateCanaryService for v1alpha1 Signed-off-by: yunbo <yunbo10124scut@gmail.com>
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zmberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: yunbo <yunbo10124scut@gmail.com>
Signed-off-by: yunbo <yunbo10124scut@gmail.com>
…idering case-insensitivity. (openkruise#200) * Fixed a bug caused by NOT considering case-insensitivity. Signed-off-by: yunbo <yunbo10124scut@gmail.com> * add DisableGenerateCanaryService for CanaryStrategy amend1: update crd yaml amend2: add DisableGenerateCanaryService for v1alpha1 Signed-off-by: yunbo <yunbo10124scut@gmail.com> --------- Signed-off-by: yunbo <yunbo10124scut@gmail.com> Co-authored-by: yunbo <yunbo10124scut@gmail.com> Signed-off-by: Megrez Lu <lujiajing1126@gmail.com>
* support queryparams for gateway api Signed-off-by: Megrez Lu <lujiajing1126@gmail.com> * support mse Signed-off-by: Megrez Lu <lujiajing1126@gmail.com> * support path and queryParams Signed-off-by: Megrez Lu <lujiajing1126@gmail.com> * fix lint Signed-off-by: Megrez Lu <lujiajing1126@gmail.com> * fix testcase Signed-off-by: Megrez Lu <lujiajing1126@gmail.com> * fix manifests Signed-off-by: Megrez Lu <lujiajing1126@gmail.com> * do not provide default value for path Signed-off-by: Megrez Lu <lujiajing1126@gmail.com> * Allow Not generating Canary Service && Fixed a bug caused by NOT considering case-insensitivity. (#200) * Fixed a bug caused by NOT considering case-insensitivity. Signed-off-by: yunbo <yunbo10124scut@gmail.com> * add DisableGenerateCanaryService for CanaryStrategy amend1: update crd yaml amend2: add DisableGenerateCanaryService for v1alpha1 Signed-off-by: yunbo <yunbo10124scut@gmail.com> --------- Signed-off-by: yunbo <yunbo10124scut@gmail.com> Co-authored-by: yunbo <yunbo10124scut@gmail.com> Signed-off-by: Megrez Lu <lujiajing1126@gmail.com> * revert test images Signed-off-by: Megrez Lu <lujiajing1126@gmail.com> * polish comments Signed-off-by: Megrez Lu <lujiajing1126@gmail.com> * add gateway api tests Signed-off-by: Megrez Lu <lujiajing1126@gmail.com> * fix MSE cases Signed-off-by: Megrez Lu <lujiajing1126@gmail.com> * update golang lint ci Signed-off-by: Megrez Lu <lujiajing1126@gmail.com> * regenerate manifests Signed-off-by: Megrez Lu <lujiajing1126@gmail.com> * remove generic usage Signed-off-by: Megrez Lu <lujiajing1126@gmail.com> * update istio lua script Signed-off-by: Megrez Lu <lujiajing1126@gmail.com> * update v1alpha1 in e2e to v1beta1 Signed-off-by: Megrez Lu <lujiajing1126@gmail.com> * fix cases Signed-off-by: Megrez Lu <lujiajing1126@gmail.com> * refactor istio case to include queryParams and path Signed-off-by: Megrez Lu <lujiajing1126@gmail.com> * fix cloneset issue Signed-off-by: Megrez Lu <lujiajing1126@gmail.com> * fix typo Signed-off-by: Megrez Lu <lujiajing1126@gmail.com> * revert images Signed-off-by: Megrez Lu <lujiajing1126@gmail.com> --------- Signed-off-by: Megrez Lu <lujiajing1126@gmail.com> Signed-off-by: yunbo <yunbo10124scut@gmail.com> Co-authored-by: myname4423 <57184070+myname4423@users.noreply.github.com> Co-authored-by: yunbo <yunbo10124scut@gmail.com>
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
NO
Ⅲ. Special notes for reviews
For 1:
when working with trafficRoutings.customNetworkRefs (such as VirtualService and DestinationRule for Istio), rollout will always generate canary Service based on the provided Service, which may be undesirable in the scenario of using DestinationRule subsets.
For 2:
In the code within
api/v1alpha1/conversion.go
, when converting objects from v1alpha1 to v1beta1 (aka. the HUB version), a direct string comparison is made. This leads to an issue where v1alpha1 objects (Rollout and batchRelease) are only converted correctly to the v1beta1 object if the RolloutStyleAnnotation annotation is exactly "Partition" (with an uppercase initial letter). In other cases, where RolloutStyleAnnotation is "partition", "canary", or "Canary", the conversion defaults to the canary.