Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inventory messages when nereid_catalog_variants is present #7571 #363

Merged
merged 1 commit into from
May 5, 2015

Conversation

PritishC
Copy link
Contributor

@PritishC PritishC commented May 1, 2015

No description provided.

@PritishC
Copy link
Contributor Author

PritishC commented May 1, 2015

screen_010

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.71%) to 68.97% when pulling 0024a19 on PritishC:feature/task-7571 into d66868a on openlabs:develop.

// Remove the disabled attribute from the buy now button.
$('#buy-now-btn').removeAttr('disabled');
} else {
statusClass = 'danger';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add disabled Attr to buy button

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@PritishC PritishC force-pushed the feature/task-7571 branch 3 times, most recently from 7196e70 to 544ebf0 Compare May 1, 2015 18:14
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.71%) to 68.97% when pulling 544ebf0 on PritishC:feature/task-7571 into d66868a on openlabs:develop.

@tarunbhardwaj
Copy link
Contributor

LGTM

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.71%) to 68.97% when pulling 544ebf0 on PritishC:feature/task-7571 into d66868a on openlabs:develop.


if purpose == 'variant_selection':
res.update({
'inventory_status': self.inventory_status(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this method is in nereid-catalog-variant then this implementation should be there only.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nereid-catalog-variants is not dependent on nereid-cart-b2c. Hence the serialize method had to be overriden here itself.

* Also fixed jinja portion for color consistency
* Tested that serialize works with catalog-variants present
@coveralls
Copy link

Coverage Status

Coverage increased (+0.44%) to 70.11% when pulling 9584b92 on PritishC:feature/task-7571 into d66868a on openlabs:develop.

tarunbhardwaj added a commit that referenced this pull request May 5, 2015
Fix inventory messages when nereid_catalog_variants is present #7571
@tarunbhardwaj tarunbhardwaj merged commit c30affc into openlabs:develop May 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants