Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tooltip when product is already added in cart #7727 #372

Merged
merged 2 commits into from
May 18, 2015

Conversation

gautampanday
Copy link
Contributor

No description provided.

@@ -466,8 +466,14 @@
$.each(lines, function(index, line) {
$(".product-" + line.product.id + "-buy-now-btn")
.attr('disabled', 'disabled');
var disable_check=$('.product-buy-now').prop('disabled')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

;

@coveralls
Copy link

Coverage Status

Coverage remained the same at 70.11% when pulling 4ad15a4 on gautampanday:task-7727 into 7cff64c on openlabs:develop.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 70.11% when pulling 77b3d65 on gautampanday:task-7727 into 7cff64c on openlabs:develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 70.11% when pulling 77b3d65 on gautampanday:task-7727 into 7cff64c on openlabs:develop.

@@ -466,8 +466,14 @@
$.each(lines, function(index, line) {
$(".product-" + line.product.id + "-buy-now-btn")
.attr('disabled', 'disabled');
var disable_check=$('.product-buy-now').prop('disabled');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isDisabled?

@GauravButola
Copy link
Contributor

LGTM.

@gautampanday gautampanday force-pushed the task-7727 branch 2 times, most recently from 5be6d71 to f565313 Compare May 14, 2015 10:19
@coveralls
Copy link

Coverage Status

Coverage remained the same at 70.11% when pulling 5be6d71 on gautampanday:task-7727 into 7cff64c on openlabs:develop.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 70.11% when pulling f565313 on gautampanday:task-7727 into 7cff64c on openlabs:develop.

@gautampanday
Copy link
Contributor Author

add-cart-top

@coveralls
Copy link

Coverage Status

Coverage remained the same at 70.11% when pulling c965c74 on gautampanday:task-7727 into 7cff64c on openlabs:develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 70.11% when pulling c965c74 on gautampanday:task-7727 into 7cff64c on openlabs:develop.

.done(function(result){
$(".cart-message").removeClass("hidden").show().delay(3000).fadeOut();
$(".cart-add-msg").html(function() {
return '<div class="col-sm-5">' + '<img class="img-responsive"' + "src=" + result.line.image + ">" + "</div>" + '<div class="col-sm-7">' + "<p>" + result.line.display_name + "<br>" + "added to your cart" + "</p>" + "</div>";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use underscore js template. which is already being used in rendering cart dropdown

@gautampanday gautampanday force-pushed the task-7727 branch 2 times, most recently from cd6318a to 6c08a66 Compare May 16, 2015 07:32
@coveralls
Copy link

Coverage Status

Coverage remained the same at 70.11% when pulling 6c08a66 on gautampanday:task-7727 into a76a0ab on openlabs:develop.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 70.11% when pulling 6c08a66 on gautampanday:task-7727 into a76a0ab on openlabs:develop.

@gautampanday gautampanday force-pushed the task-7727 branch 2 times, most recently from c6ec7c1 to 7e379c3 Compare May 16, 2015 08:56
@coveralls
Copy link

Coverage Status

Coverage remained the same at 70.11% when pulling 7e379c3 on gautampanday:task-7727 into a76a0ab on openlabs:develop.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 70.11% when pulling 7e379c3 on gautampanday:task-7727 into a76a0ab on openlabs:develop.

.done(function(result){
$(".cart-message").removeClass("hidden").show();
var template = $("#cart-message").html();
$(".cart-add-msg").html(_.template(template, {'result': result}));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line: result.line

@coveralls
Copy link

Coverage Status

Coverage remained the same at 70.11% when pulling fe5953e on gautampanday:task-7727 into a76a0ab on openlabs:develop.

tarunbhardwaj added a commit that referenced this pull request May 18, 2015
Added tooltip when product is already added in cart #7727
@tarunbhardwaj tarunbhardwaj merged commit e1a72c3 into openlabs:develop May 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants