Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support tree_node and category for navigation #4721 #75

Merged
merged 1 commit into from
Jun 28, 2014
Merged

Support tree_node and category for navigation #4721 #75

merged 1 commit into from
Jun 28, 2014

Conversation

sharoonthomas
Copy link
Contributor

product.tree_node is a far better hierarchial classification system
than product.category. Despite this, some sites may want to stay simple
and use category (which they might already use) for navigation.

This patch separates the rendering of top site navigation into _helpers
as two macros, for category and tree_node. Depending on the root navigation
model specified for the current website, the appropriate one is used

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling ba41611 on sharoonthomas:task-4721 into df3479c on openlabs:develop.

product.tree_node is a far better hierarchial classification system
than product.category. Despite this, some sites may want to stay simple
and use category (which they might already use) for navigation.

This patch separates the rendering of top site navigation into _helpers
as two macros, for category and tree_node. Depending on the root navigation
model specified for the current website, the appropriate one is used
@sharoonthomas sharoonthomas changed the title Support tree_code and category for navigation #4721 Support tree_node and category for navigation #4721 Jun 28, 2014
prakashpp pushed a commit that referenced this pull request Jun 28, 2014
Support tree_node and category for navigation #4721
@prakashpp prakashpp merged commit ebbc1fb into openlabs:develop Jun 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants