Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for setTrace Notification #162

Closed
karthiknadig opened this issue Mar 24, 2021 · 4 comments
Closed

Add support for setTrace Notification #162

karthiknadig opened this issue Mar 24, 2021 · 4 comments

Comments

@karthiknadig
Copy link
Contributor

This is used by LS client to set the tracing level on the server. Looks like this was added in LSP 3.16 (https://microsoft.github.io/language-server-protocol/specifications/specification-current/#setTrace)

Failed to handle notification $/setTrace: Object(value='verbose')
Traceback (most recent call last):
  File "c:\Users\karth\.vscode\extensions\ms-python.python-2021.3.680753044\pythonFiles\lib\jedilsp\pygls\protocol.py", line 279, in _get_handler
    return self.fm.builtin_features[feature_name]
KeyError: '$/setTrace'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "c:\Users\karth\.vscode\extensions\ms-python.python-2021.3.680753044\pythonFiles\lib\jedilsp\pygls\protocol.py", line 282, in _get_handler
    return self.fm.features[feature_name]
KeyError: '$/setTrace'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "c:\Users\karth\.vscode\extensions\ms-python.python-2021.3.680753044\pythonFiles\lib\jedilsp\pygls\protocol.py", line 306, in _handle_notification
    handler = self._get_handler(method_name)
  File "c:\Users\karth\.vscode\extensions\ms-python.python-2021.3.680753044\pythonFiles\lib\jedilsp\pygls\protocol.py", line 284, in _get_handler
    raise JsonRpcMethodNotFound.of(feature_name)
pygls.exceptions.JsonRpcMethodNotFound
@danixeee
Copy link
Contributor

Yes, they are constantly changing specs. Looking at the changelog, I will need to update few more things.

@danixeee
Copy link
Contributor

@karthiknadig Actually, everything from 3.16 needs to be added.

@karthiknadig
Copy link
Contributor Author

@danixeee I can help with this. Should I create a issue for each item to be added? Should 3.16 work go in a separate branch?

@danixeee
Copy link
Contributor

@karthiknadig I don't mind having only one issue if you plan to address all changes for 3.16. I think I won't have time to work on it this week.

I believe you go through recently modified files here and check everything that has @since 3.16 in docstring. That should be easier than going through the specification document.

danixeee added a commit that referenced this issue May 26, 2021
@danixeee danixeee mentioned this issue Jun 7, 2021
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants