Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for setTrace Notification #103

Closed
karthiknadig opened this issue Mar 24, 2021 · 3 comments
Closed

Add support for setTrace Notification #103

karthiknadig opened this issue Mar 24, 2021 · 3 comments
Labels

Comments

@karthiknadig
Copy link
Contributor

This is used by LS client to set the tracing level on the server.

Failed to handle notification $/setTrace: Object(value='verbose')
Traceback (most recent call last):
  File "c:\Users\karth\.vscode\extensions\ms-python.python-2021.3.680753044\pythonFiles\lib\jedilsp\pygls\protocol.py", line 279, in _get_handler
    return self.fm.builtin_features[feature_name]
KeyError: '$/setTrace'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "c:\Users\karth\.vscode\extensions\ms-python.python-2021.3.680753044\pythonFiles\lib\jedilsp\pygls\protocol.py", line 282, in _get_handler
    return self.fm.features[feature_name]
KeyError: '$/setTrace'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "c:\Users\karth\.vscode\extensions\ms-python.python-2021.3.680753044\pythonFiles\lib\jedilsp\pygls\protocol.py", line 306, in _handle_notification
    handler = self._get_handler(method_name)
  File "c:\Users\karth\.vscode\extensions\ms-python.python-2021.3.680753044\pythonFiles\lib\jedilsp\pygls\protocol.py", line 284, in _get_handler
    raise JsonRpcMethodNotFound.of(feature_name)
pygls.exceptions.JsonRpcMethodNotFound
@pappasam
Copy link
Owner

pappasam commented Mar 24, 2021

Hmm, this may be worth filing with pygls under 3.16 support (I think $/setTrace was introduced in 3.16). The most recent release FINALLY (supposedly) supports everything from 3.15. We might consider writing a patch / dummy function at least not raise an error.

That said, I'm not sure how I'd go about addressing this effectively on my end since I don't use VSCode / my client doesn't yet support 3.16 so I'll have a hard time knowing whether an implementation provides the intended behavior / workarounds.

@karthiknadig
Copy link
Contributor Author

Opened openlawlibrary/pygls#162

@pappasam
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants