-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix signature verification link #205
Conversation
remove unused class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to make a regression test for this with our current test infrastructure?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if I got the idea here. Do we need to build the link to the signature proof on openlaw core? Because it depends on openlaw app context. Could we just instantiate the link on openlaw app with the proper data? I mean, for each change in the app context it will require a new change in the core lib to fix the context.
The issue here is that this is part of the rendering process, i.e. we need to generate this link within the rendering process. So for now, this is the solution we have found. We can def. create an issue to extract that (or actually just put a pin on it for when we're going to work more on the signature process) so we don't have this issue anymore. I agree this is not an ideal architecture but this is what works right now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I just raised the new ticket #207
This PR does 2 things:
This change is