-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: New Adapter - Manager #541
Conversation
Codecov Report
@@ Coverage Diff @@
## master #541 +/- ##
==========================================
+ Coverage 90.72% 90.95% +0.22%
==========================================
Files 52 53 +1
Lines 1866 1912 +46
Branches 438 448 +10
==========================================
+ Hits 1693 1739 +46
Misses 173 173
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nickmzero it looks very good. I added some minor comments about the tests and suggestion about adding the proposalId
as part of the signature.
@fforbeck thanks. I've added |
Proposed Changes
Adds the Manager adapter which allows DAO operators to update adapters/extensions/configs by submitting an EIP712 signature along with the proposal, skipping the existing proposal/voting process