Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New Adapter - Manager #541

Merged
merged 7 commits into from
Jun 7, 2022
Merged

feat: New Adapter - Manager #541

merged 7 commits into from
Jun 7, 2022

Conversation

nickmzero
Copy link
Collaborator

Proposed Changes

Adds the Manager adapter which allows DAO operators to update adapters/extensions/configs by submitting an EIP712 signature along with the proposal, skipping the existing proposal/voting process

@codecov
Copy link

codecov bot commented Jun 6, 2022

Codecov Report

Merging #541 (710d7d1) into master (58f7016) will increase coverage by 0.22%.
The diff coverage is 100.00%.

❗ Current head 710d7d1 differs from pull request most recent head 7319141. Consider uploading reports for the commit 7319141 to get more accurate results

@@            Coverage Diff             @@
##           master     #541      +/-   ##
==========================================
+ Coverage   90.72%   90.95%   +0.22%     
==========================================
  Files          52       53       +1     
  Lines        1866     1912      +46     
  Branches      438      448      +10     
==========================================
+ Hits         1693     1739      +46     
  Misses        173      173              
Impacted Files Coverage Δ
contracts/adapters/Manager.sol 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58f7016...7319141. Read the comment docs.

Copy link
Contributor

@fforbeck fforbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nickmzero it looks very good. I added some minor comments about the tests and suggestion about adding the proposalId as part of the signature.

contracts/adapters/Manager.sol Outdated Show resolved Hide resolved
contracts/adapters/Manager.sol Show resolved Hide resolved
test/adapters/manager.test.js Outdated Show resolved Hide resolved
test/adapters/manager.test.js Outdated Show resolved Hide resolved
test/adapters/manager.test.js Outdated Show resolved Hide resolved
@fforbeck fforbeck changed the title Tf 13 feat: New Adapter - Manager Jun 7, 2022
@nickmzero
Copy link
Collaborator Author

@nickmzero it looks very good. I added some minor comments about the tests and suggestion about adding the proposalId as part of the signature.

@fforbeck thanks. I've added proposalId to the signature and updated the descriptions of those tests

@fforbeck fforbeck merged commit c545c98 into master Jun 7, 2022
@fforbeck fforbeck deleted the tf-13 branch June 7, 2022 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants