Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QueryStringFilter in HTTP Protocol #147

Closed
probins opened this issue Jan 14, 2012 · 4 comments
Closed

QueryStringFilter in HTTP Protocol #147

probins opened this issue Jan 14, 2012 · 4 comments

Comments

@probins
Copy link
Contributor

probins commented Jan 14, 2012

Currently, there's a dependency for this with the note "remove this dependency in 3.0". Protocol/Script has similar logic yet there's no dependency. Why does removing it have to wait for 3.0? Can we not get rid of it now? Surely, by definition, a QueryStringFilter is only required if there is a query string to filter, which in many cases with HTTP protocol there isn't..

@fredj
Copy link
Member

fredj commented Jan 14, 2012

+1 to remove this dependency; a note into notes/2.12.md is suffisant.

@elemoine
Copy link
Member

I'm also fine with removing the dependency. So long that we have a note in 2.12.md.

@tschaub
Copy link
Member

tschaub commented Jan 17, 2012

@probins: to answer the questions you pose in the description, the dependency was added when we separated logic from the HTTP protocol (see 49e96f3). Since this logic had been included in a previous 2.x release, to maintain backwards compatibility, the dependency was added. For the Script protocol, this optional functionality was added between releases, so you always only got it when you included the extra dependency explicitly.

@probins
Copy link
Contributor Author

probins commented Jan 17, 2012

Can be closed as #148 merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants