Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove QueryStringFilter requires from Protocol/HTTP #148

Merged
merged 2 commits into from
Jan 17, 2012
Merged

Remove QueryStringFilter requires from Protocol/HTTP #148

merged 2 commits into from
Jan 17, 2012

Conversation

probins
Copy link
Contributor

@probins probins commented Jan 14, 2012

see #147

No logic changes; only affects builds

@elemoine
Copy link
Member

I'm +1 with this change. But I'd like to have @tschaub's opinion, since he's the one who said the dependency should be removed in 3.0.

@tschaub
Copy link
Member

tschaub commented Jan 17, 2012

I added that comment so behavior would remain unchanged for people using this functionality. I'm ok with the change assuming there is an accompanying comment in the release notes. I do think there is some caution warranted here - we risk making it extremely hard to get a proper build by having all this optional functionality (and only having it documented in the release notes).

@elemoine
Copy link
Member

@tschaub, I agree. Maybe we should merge this one and stop making such changes for 2.12. We may also want to have a "script dependency changes" section in the release notes, where we explain clearly how build profiles need to be changed.

The current master already includes lots of changes compared to 2.11, with some of them somewhat disruptive for users (e.g. deprecated.js, the script dependency changes). We may want to stop and think about releasing 2.12.

elemoine pushed a commit that referenced this pull request Jan 17, 2012
Remove QueryStringFilter requires from Protocol/HTTP
@elemoine elemoine merged commit 6373cce into openlayers:master Jan 17, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants