Move mercator transforms to Projection.js. #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SphericalMercator mixin is not required for coordinate transforms. Default transforms included whenever Projection.js is included.
|
Awesome. We may just want something in the release notes for this change. Thank you for making this real. Please merge. |
|
Wow! Fast work! We can also remove the SphericalMercator dependency that @elemoine has just added to Layer/OSM :-) One small api change from removing SphericalMercator from Bing that has just occurred to me is that forwardMercator() and inverseMercator() are api methods, so it's possible (though probably not very likely) that people were using them (with OpenLayers.Layer.SphericalMercator.forwardMercator(...)). This will no longer work if SphericalMercator isn't present. So, yes, I agree that something to this effect should be in the release notes. |
Projection.js gets pulled in as a transitive dependency of all layers.
The default transforms (b/w EPSG:4326 & EPSG:900913) now come with any layer type.
This adds documentation for projection methods and includes detail in the release notes about build configuration related changes.
tschaub
added a commit
that referenced
this pull request
Jan 17, 2012
Move mercator transforms to Projection.js.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SphericalMercator mixin is not required for coordinate transforms. Default transforms included whenever Projection.js is included.