Conditional default prevention instead of touch-action: none #10332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahocevar
force-pushed
the
no-touch-action-css
branch
3 times, most recently
from
23070c3
to
243686f
Compare
ahocevar
force-pushed
the
no-touch-action-css
branch
from
243686f
to
88b8b2f
Compare
DaniEll-AT
approved these changes
Nov 28, 2019
fredj
approved these changes
Nov 29, 2019
ahocevar
added a commit
to ahocevar/openlayers
that referenced
this pull request
Nov 30, 2019
ahocevar
added a commit
that referenced
this pull request
Dec 1, 2019
Remove line that was accidently added with #10332
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this pull request, users get more fine-grained control over default prevention on touch devices. Previously, we always set the
touch-action: nonecss property on the viewport, which prevents the default on all touch events. This is not desired for maps embedded on scrollable pages. Now we don't settouch-actionany more. Instead, theDragPaninteraction callspreventDefault()ontouchmove. With this change, users can configureDragPanwith a condition that checks for the number of pointers (with its newgetPointerCount()method), and only handle the event when more than one finger is used.This change also removes the no longer needed, only recently introduced code (#10187) that changes the
touch-actioncss property on the viewport dynamically.Fixes #9936.