Update TypeScript to v3.8 #10934
Merged
Update TypeScript to v3.8 #10934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow. Thanks for all the careful work on this, @ahocevar. Odd not to see a CircleCI pipeline running for this. I wonder if you need to push a new commit. |
tschaub
reviewed
Apr 15, 2020
| @@ -290,7 +290,7 @@ class CanvasTileLayerRenderer extends CanvasLayerRenderer { | |||
|
|
|||
| // set scale transform for calculating tile positions on the canvas | |||
| composeTransform( | |||
| this.tempTransform_, | |||
| this.tempTransform, | |||
There was a problem hiding this comment.
I'm happy to see all these _ suffixed properties go.
tschaub
approved these changes
Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes several fixes related to types, which allows us to upgrade to the latest TypeScript version.
Most issues were around private/protected/public scope problems. I resolved some of them by refactoring the way we pass functions to the contstructor (e.g.
tileUrlFunction). Now we simply rely on inheritance for that. A broader field of problems were the XML formats. Due to the way these allow matching and mixing properties and functions from other formats, I had to remove private/protected restrictions from these properties and functions.This pull request also contains one commit that works around microsoft/TypeScript#33575, b0f20d6 to make
npm run typecheckpass. We might be able to revert that commit when the TypeScript issue is fixed. Also, until that TypeScript issue is fixed, enum types in applications still do not work correctly.When these changes are in, TypeScript projects can also benefit from the types that are directly derived from the sources in the package's
src/folder.