Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#11402 add CSS class name support for control buttons #11403

Merged
merged 12 commits into from
Oct 10, 2020

Conversation

cazacugmihai
Copy link
Contributor

@cazacugmihai cazacugmihai commented Aug 6, 2020

This PR fixes #11402.

@cazacugmihai cazacugmihai changed the title #11402 add CSS class name support for zoom buttons #11402 add CSS class name support for control buttons Aug 6, 2020
@stale
Copy link

stale bot commented Oct 7, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 7, 2020
@cazacugmihai
Copy link
Contributor Author

Can someone look over this PR, please?

Copy link
Member

@ahocevar ahocevar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks, @cazacugmihai.

@ahocevar ahocevar merged commit de5287a into openlayers:main Oct 10, 2020
@ahocevar
Copy link
Member

c53ff62 introduced a regression: the Rotate button's arrow does not indicate the map rotation any more - it is always upright.

@ahocevar
Copy link
Member

Actually just a typo, but a fatal one. I created #11754 to fix this regression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add CSS class name support control buttons
2 participants