Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch reworks things to work with webpack@5 and the latest rollup plugins.
The
examples/webpack/example-builder.js
plugin needed to be updated to conform with the new webpack plugin API.The
tasks/serialize-workers.js
script needed to be updated to work with the latest babel plugin for rollup.I've confirmed that examples are properly built and served with
npm start
, that the production build of the examples withnpm run build-examples
look good, that the legacy build withnpm run build-legacy
still works, and thatnpm run build-package
still works.The examples take about 20 seconds longer to build in production mode compared to building with webpack 4 (building examples in dev mode takes about 5 seconds longer). I think it is a known issue that webpack 5 is slower (webpack/webpack#12102). Maybe we can expect improvements in future releases.
I don't think we have to migrate things right now if we don't want to. But I wanted to see what was involved in updating our plugins.
Closes #12133.